Author Alexander.Belopolsky
Recipients Alexander.Belopolsky, akitada, belopolsky, christian.heimes, josm, loewis, mark.dickinson, rhettinger, robertwb, zanella
Date 2010-05-04.12:41:25
SpamBayes Score 4.80298e-06
Marked as misclassified No
Message-id <3F29EB94-2602-4D17-B218-A041980D2CE6@gmail.com>
In-reply-to <1272976444.89.0.608433964524.issue1533@psf.upfronthosting.co.za>
Content
I see. Let me take a look.

BTW, I tried to use tabs for indentation in the patch, but emacs was  
not always happy about it. Is there some c-mode setting that I don't  
know about that would take care of that?

On May 4, 2010, at 8:34 AM, Mark Dickinson <report@bugs.python.org>  
wrote:

>
> Mark Dickinson <dickinsm@gmail.com> added the comment:
>
> Hi Alexander,
>
> I took the liberty of messing with your patch slightly;  I didn't  
> want to ask you to make further changes since the patch was fine,  
> and my messing was mostly just to satisfy my own fussiness (only the  
> first two items were really necessary):
>
> Minor updates:
> - add Misc/NEWS entry
> - remove trailing whitespace and fix spaces that should have been a  
> tab
> - added some extra tests to check all possible combinations of bad
>   arguments, purely to check for refcounting problems
> - initialize low to NULL, to match the Py_XDECREF(low) (could change
>   that Py_XDECREF to Py_DECREF instead, but the code's more resistant
>   to random refactorings this way --- see next item :)
> - randomly refactor:  regroup blocks for ease of reading
> - don't do PyLong_FromLong(1) until it's needed ('zero' is different,
>   since it's always used in the non-error case)
> - [micro-optimization]: don't pass a known zero value to
>   get_range_long_argument
>
> Any objections or comments?  Can I apply this version of the patch?
>
> ----------
> Added file: http://bugs.python.org/file17200/issue1533_metd.diff
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue1533>
> _______________________________________
History
Date User Action Args
2010-05-04 12:41:28Alexander.Belopolskysetrecipients: + Alexander.Belopolsky, loewis, rhettinger, mark.dickinson, belopolsky, christian.heimes, josm, robertwb, zanella, akitada
2010-05-04 12:41:26Alexander.Belopolskylinkissue1533 messages
2010-05-04 12:41:25Alexander.Belopolskycreate