Author ncoghlan
Recipients brett.cannon, collinwinter, jd, loewis, mlobo, ncoghlan, skip.montanaro
Date 2010-04-29.13:43:44
SpamBayes Score 2.65633e-05
Marked as misclassified No
Message-id <1272548627.45.0.110281650566.issue1644818@psf.upfronthosting.co.za>
In-reply-to
Content
OK, reassessing with brain fully engaged this time: the current patch is incorrect, and this request is more complicated than one might initially think :)

It appears that since the patch was originally tried out only on Windows, a Modules/Setup based system based system like mine can't even build a patched tree. The current incarnation of the Modules/makesetup script won't allow the use of a dotted name for a module named in Modules/Setup.

Anyway, I'm uploading a more fleshed out test case which explicitly details some of the module namespace invariants that built-in packages would need to support (and changing the issue type and title accordingly).

Even beyond these stricter tests, pkgutil and importlib would need to be checked to make sure they also support the new behaviour. 

Since I can't build the patch as it currently stands, I don't know how well it actually fairs against the stronger set of invariants. However, just looking at the patch I'm pretty confident that it doesn't include the necessary work to make sure that the parent package actually looks like a package from the interpreter's point of view.
History
Date User Action Args
2010-04-29 13:43:47ncoghlansetrecipients: + ncoghlan, loewis, skip.montanaro, brett.cannon, collinwinter, mlobo, jd
2010-04-29 13:43:47ncoghlansetmessageid: <1272548627.45.0.110281650566.issue1644818@psf.upfronthosting.co.za>
2010-04-29 13:43:46ncoghlanlinkissue1644818 messages
2010-04-29 13:43:45ncoghlancreate