Author orsenthil
Recipients barry, bgamari, gdamjan, haypo, l0nwlf, loewis, maxua, orsenthil, r.david.murray
Date 2010-04-28.07:29:07
SpamBayes Score 0.000443523
Marked as misclassified No
Message-id <1272439750.05.0.661744431878.issue1368247@psf.upfronthosting.co.za>
In-reply-to
Content
Hi David,
The attached patch for this issue:

+        if isinstance(payload, unicode):
+            payload = payload.encode(msg.get_charset().output_charset or 'us-ascii')

looks fine enough to me. Are you worried about the /or 'us-ascii'/ part of this patch? 

IMHO, the patch may prevent the straight forward Exception for which the issue was raised.

But on a larger scale, it is advisable to document MIMEText usage wth encoding as you mentioned.
History
Date User Action Args
2010-04-28 07:29:11orsenthilsetrecipients: + orsenthil, loewis, barry, haypo, gdamjan, maxua, r.david.murray, bgamari, l0nwlf
2010-04-28 07:29:10orsenthilsetmessageid: <1272439750.05.0.661744431878.issue1368247@psf.upfronthosting.co.za>
2010-04-28 07:29:08orsenthillinkissue1368247 messages
2010-04-28 07:29:07orsenthilcreate