Message 103779 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	doerwalter, lemburg, loewis, pitrou, vstinner
Date	2010-04-20.21:59:51
SpamBayes Score	1.2191581e-11
Marked as misclassified	No
Message-id	<1271800792.71.0.418742518298.issue8092@psf.upfronthosting.co.za>
In-reply-to

Content
Oops, I forgot the remove the reallocation in the unicode case in the patch version 2. Patch version 3: - micro-optimization: group both surrogates cases in the same if to avoid checking 0xD800 <= ch twice - check for integer overflow - (remove the duplication reallocation introduced by version 2) I think that PyUnicode_EncodeUTF8() is more readable after my patch: there maximum if depth is 2 instead of 3, and I removed the goto. It shouldn't change anything about performances for chacters < 0x800 (ASCII and Latin-1), and I expect similar performances for characters >= 0x800.

Oops, I forgot the remove the reallocation in the unicode case in the patch version 2.

Patch version 3:
 - micro-optimization: group both surrogates cases in the same if to avoid checking 0xD800 <= ch twice
 - check for integer overflow
 - (remove the duplication reallocation introduced by version 2)

I think that PyUnicode_EncodeUTF8() is more readable after my patch: there maximum if depth is 2 instead of 3, and I removed the goto.

It shouldn't change anything about performances for chacters < 0x800 (ASCII and Latin-1), and I expect similar performances for characters >= 0x800.

History
Date	User	Action	Args
2010-04-20 21:59:52	vstinner	set	recipients: + vstinner, lemburg, loewis, doerwalter, pitrou
2010-04-20 21:59:52	vstinner	set	messageid: <1271800792.71.0.418742518298.issue8092@psf.upfronthosting.co.za>
2010-04-20 21:59:51	vstinner	link	issue8092 messages
2010-04-20 21:59:51	vstinner	create