Author orsenthil
Recipients Keegan.Carruthers-Smith, benjamin.peterson, eric.araujo, jjlee, ndim, orsenthil, pitrou, r.david.murray, sergiomb2, tlocke
Date 2010-04-20.20:51:37
SpamBayes Score 2.01607e-09
Marked as misclassified No
Message-id <1271796699.04.0.226117972069.issue2987@psf.upfronthosting.co.za>
In-reply-to
Content
I added an additional invalid test which David pointed out and made changes to invalid url checking code. I moved it more higher level.

- The reason for doing this is, invalid url test code (which is very specific for '[' enclosed ']' ipv6 url is concentrated at a single place). We can deal with parsing separately from check.

Now, other forms of Invalid URLs are possible as David points out (and possibly more too), but leaving it is better as it would unnecessarily add syntax-checks at various different places (instead of a single place), without much of value add.  Dealing with Valid URLs and a parse logic checking should be fine.

commits: trunk - r80277 and py3k - r80278
History
Date User Action Args
2010-04-20 20:51:39orsenthilsetrecipients: + orsenthil, jjlee, pitrou, benjamin.peterson, ndim, eric.araujo, r.david.murray, sergiomb2, tlocke, Keegan.Carruthers-Smith
2010-04-20 20:51:39orsenthilsetmessageid: <1271796699.04.0.226117972069.issue2987@psf.upfronthosting.co.za>
2010-04-20 20:51:37orsenthillinkissue2987 messages
2010-04-20 20:51:37orsenthilcreate