Author pitrou
Recipients eric.smith, jafo, pitrou
Date 2010-04-19.10:34:24
SpamBayes Score 4.60736e-09
Marked as misclassified No
Message-id <1271673265.9.0.460985573585.issue8451@psf.upfronthosting.co.za>
In-reply-to
Content
Some notes about the patch:

- NEWS blurbs generally appear antichronologically, that is newest first :-)
- you don't have to mention that "The 3.2 changes mentioned above are included in 2.7"
- the part of the PyArg_ParseTupleAndKeywords string after the semi-colon is supposed to be a custom error message, which "[ident string [, logoption [, facility]]]" doesn't look like; how about simply using a colon and putting the function name?
- you should check PyList_Size()'s return value for error (sys.argv could have been overriden to something else than a list)
- similarly, scriptobj is not guaranteed to be a string object, so you have to check for that too
- to check for string length > 0, it looks more natural to check either that script[0] != 0, or that PyString_GET_SIZE(...) > 0 (rather than calling PyObject_IsTrue())
- why do you Py_INCREF() the "openargs" tuple? It looks like a reference leak
- if PyTuple_New(0) fails (which I admit is highly unlikely), you should free all other resources and bail out
- when manually calling syslog_openlog(), you should check the return value and either Py_DECREF it (if non-NULL) or bail out
History
Date User Action Args
2010-04-19 10:34:26pitrousetrecipients: + pitrou, jafo, eric.smith
2010-04-19 10:34:25pitrousetmessageid: <1271673265.9.0.460985573585.issue8451@psf.upfronthosting.co.za>
2010-04-19 10:34:24pitroulinkissue8451 messages
2010-04-19 10:34:24pitroucreate