Author pitrou
Recipients giampaolo.rodola, janssen, pitrou
Date 2010-03-24.16:33:18
SpamBayes Score 0.00046693
Marked as misclassified No
Message-id <1269448401.87.0.655952787423.issue8222@psf.upfronthosting.co.za>
In-reply-to
Content
In light of the recv() and recv_into() implementation change (issue3890), I think we should enable SSL_MODE_AUTO_RETRY for SSL sockets. It prevents blocking read() calls from getting SSL_ERROR_WANT_READ at all.
(previously, we would loop manually in recv() and recv_into(); letting
the C OpenSSL runtime do it for us is certainly more efficient)

See description in
http://www.openssl.org/docs/ssl/SSL_CTX_set_mode.html:

« SSL_MODE_AUTO_RETRY

        Never bother the application with retries if the transport is
        blocking. If a renegotiation take place during normal operation,
        a SSL_read(3) or SSL_write(3) would return with -1 and indicate
        the need to retry with SSL_ERROR_WANT_READ. In a non-blocking
        environment applications must be prepared to handle incomplete
        read/write operations. In a blocking environment, applications
        are not always prepared to deal with read/write operations
        returning without success report. The flag SSL_MODE_AUTO_RETRY
        will cause read/write operations to only return after the
        handshake and successful completion. »
History
Date User Action Args
2010-03-24 16:33:22pitrousetrecipients: + pitrou, janssen, giampaolo.rodola
2010-03-24 16:33:21pitrousetmessageid: <1269448401.87.0.655952787423.issue8222@psf.upfronthosting.co.za>
2010-03-24 16:33:19pitroulinkissue8222 messages
2010-03-24 16:33:19pitroucreate