Message101640
In light of the recv() and recv_into() implementation change (issue3890), I think we should enable SSL_MODE_AUTO_RETRY for SSL sockets. It prevents blocking read() calls from getting SSL_ERROR_WANT_READ at all.
(previously, we would loop manually in recv() and recv_into(); letting
the C OpenSSL runtime do it for us is certainly more efficient)
See description in
http://www.openssl.org/docs/ssl/SSL_CTX_set_mode.html:
« SSL_MODE_AUTO_RETRY
Never bother the application with retries if the transport is
blocking. If a renegotiation take place during normal operation,
a SSL_read(3) or SSL_write(3) would return with -1 and indicate
the need to retry with SSL_ERROR_WANT_READ. In a non-blocking
environment applications must be prepared to handle incomplete
read/write operations. In a blocking environment, applications
are not always prepared to deal with read/write operations
returning without success report. The flag SSL_MODE_AUTO_RETRY
will cause read/write operations to only return after the
handshake and successful completion. » |
|
Date |
User |
Action |
Args |
2010-03-24 16:33:22 | pitrou | set | recipients:
+ pitrou, janssen, giampaolo.rodola |
2010-03-24 16:33:21 | pitrou | set | messageid: <1269448401.87.0.655952787423.issue8222@psf.upfronthosting.co.za> |
2010-03-24 16:33:19 | pitrou | link | issue8222 messages |
2010-03-24 16:33:19 | pitrou | create | |
|