This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author barry
Recipients barry, doko
Date 2010-03-15.14:32:08
SpamBayes Score 1.25131e-08
Marked as misclassified No
Message-id <1268663531.15.0.954058924849.issue8140@psf.upfronthosting.co.za>
In-reply-to
Content
+1 on this functionality being added for 2.7 and 3.2.  You also mentioned in pvt email that it would be better to patch compileall.py than py_compile.py to take advantage of the quiet and force options (which seems good to me).

I have a few comments on the diff:

* It no longer applies cleanly to trunk.  There was a recent commit that removed an unnecessary catch of KeyboardInterrupt, and I think that's what's causing the hunk reject.

* I don't like @filename and @- as the syntax for reading the compilation list from a file.  Since -f is already taken, what about adding -i<file> which tells it where to take the list from?  Of course '-i -' would mean stdin.

* Please add tests for the new functionality to test_compileall.py

Bonus points for updating this to modern Python <wink>.  E.g. using True/False instead of 1/0, and 'OSError as error' instead of 'os.error, e'.  But don't worry about that too much; I'll probably take that on as part of my PEP 3147 work. ;)
History
Date User Action Args
2010-03-15 14:32:11barrysetrecipients: + barry, doko
2010-03-15 14:32:11barrysetmessageid: <1268663531.15.0.954058924849.issue8140@psf.upfronthosting.co.za>
2010-03-15 14:32:09barrylinkissue8140 messages
2010-03-15 14:32:08barrycreate