This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients jerry.seutter, r.david.murray, vstinner
Date 2010-03-07.21:10:26
SpamBayes Score 9.06442e-12
Marked as misclassified No
Message-id <1267996236.29.0.848611475409.issue7449@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, here is my patch "version 4", based on jerry's nothreads_3.patch. Changes between version 3 and 4:

 - test_support: threading_setup() returns (1,) instead of None; reap_threads()
   simply returns the function instead of a dummy decorator
 - regrtest.py: display an error if -j/--multiprocess option is used
 - ctypes/test/test_errno.py, test_smtplib, test_socket, test_asynchat: skip
   some tests, not the whole file
 - test_logging, test_xmlrpc, test_file2k: move decorator from setUp() method
   to the class
 - test_capi: test threading variable value instead of the presence of the
   _test_thread_state function
 - test_capi, test_contextlib: move the decorator from methods to the class
 - test_multiprocessing: import threading (without try/except) after
   _multiprocessing because _multiprocessing depends on threading and so it
   will fail

All tests pass on both builds: with and without threads.

I'm not sure that my changes moving decorators from the setUp() method or other methods to the class is the right thing to do.

FYI tests skipped because of the missing thread module are listed in "xx skips unexped on linux2: ...". I don't think that it's a problem. We discuss about that on IRC and bitdancer suggested to leave regrtest.py unchanged:

"bitdancer> You should *definitely* not disable the skip message just because the threading module is missing, that would defeat the whole purpose of the message."
History
Date User Action Args
2010-03-07 21:10:36vstinnersetrecipients: + vstinner, jerry.seutter, r.david.murray
2010-03-07 21:10:36vstinnersetmessageid: <1267996236.29.0.848611475409.issue7449@psf.upfronthosting.co.za>
2010-03-07 21:10:34vstinnerlinkissue7449 messages
2010-03-07 21:10:34vstinnercreate