Message100394
Hi,
I've never before made a patch to Python, so take it with care.
A couple of comments, I reused a test where all the attachments contained an ending newline, except for the base64 one (conveniently...)
I think the comment in _bdecode that Andreas quoted before refers to base64.encodestring add an extra \n to de encoded string, but base64.decodestring can work with and without this extra \n:
>>> import base64
>>> base64.decodestring('MTIzCg==')
'123\n'
>>> base64.decodestring('MTIzCg==\n')
'123\n'
So it's not necessary to work around this in _bdecode. Let me know if it looks good to you. |
|
Date |
User |
Action |
Args |
2010-03-04 16:03:47 | Joaquin.Cuenca.Abela | set | recipients:
+ Joaquin.Cuenca.Abela, r.david.murray, athomas, esam |
2010-03-04 16:03:47 | Joaquin.Cuenca.Abela | set | messageid: <1267718627.29.0.087836597421.issue7143@psf.upfronthosting.co.za> |
2010-03-04 16:03:45 | Joaquin.Cuenca.Abela | link | issue7143 messages |
2010-03-04 16:03:45 | Joaquin.Cuenca.Abela | create | |
|