Author Joaquin.Cuenca.Abela
Recipients Joaquin.Cuenca.Abela, athomas, esam, r.david.murray
Date 2010-03-04.16:03:44
SpamBayes Score 0.000134978
Marked as misclassified No
Message-id <1267718627.29.0.087836597421.issue7143@psf.upfronthosting.co.za>
In-reply-to
Content
Hi,

I've never before made a patch to Python, so take it with care.

A couple of comments, I reused a test where all the attachments contained an ending newline, except for the base64 one (conveniently...)

I think the comment in _bdecode that Andreas quoted before refers to base64.encodestring add an extra \n to de encoded string, but base64.decodestring can work with and without this extra \n:

>>> import base64
>>> base64.decodestring('MTIzCg==')
'123\n'
>>> base64.decodestring('MTIzCg==\n')
'123\n'

So it's not necessary to work around this in _bdecode. Let me know if it looks good to you.
History
Date User Action Args
2010-03-04 16:03:47Joaquin.Cuenca.Abelasetrecipients: + Joaquin.Cuenca.Abela, r.david.murray, athomas, esam
2010-03-04 16:03:47Joaquin.Cuenca.Abelasetmessageid: <1267718627.29.0.087836597421.issue7143@psf.upfronthosting.co.za>
2010-03-04 16:03:45Joaquin.Cuenca.Abelalinkissue7143 messages
2010-03-04 16:03:45Joaquin.Cuenca.Abelacreate