Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlparse.urlunsplit should be smarter about + #52903

Closed
dabrahams mannequin opened this issue May 8, 2010 · 3 comments
Closed

urlparse.urlunsplit should be smarter about + #52903

dabrahams mannequin opened this issue May 8, 2010 · 3 comments
Assignees
@orsenthil
Labels
type-bug An unexpected behavior, bug, or error

Comments

@dabrahams
Copy link
Mannequin

dabrahams mannequin commented May 8, 2010

BPO 8657
Nosy @orsenthil, @dabrahams
Files
  • urlparse_giturl.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
closed_at = <Date 2010-05-13.03:49:07.003>
created_at = <Date 2010-05-08.02:49:07.152>
labels = ['type-bug']
title = 'urlparse.urlunsplit should be smarter about +'
updated_at = <Date 2010-05-13.03:49:07.001>
user = 'https://github.com/dabrahams'

    bugs.python.org fields:

    activity = <Date 2010-05-13.03:49:07.001>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2010-05-13.03:49:07.003>
closer = 'orsenthil'
components = []
creation = <Date 2010-05-08.02:49:07.152>
creator = 'dabrahams'
dependencies = []
files = ['17258']
hgrepos = []
issue_num = 8657
keywords = ['patch']
message_count = 3.0
messages = ['105253', '105280', '105622']
nosy_count = 3.0
nosy_names = ['orsenthil', 'meatballhat', 'dabrahams']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8657'
versions = ['Python 2.6']
    @dabrahams
    Copy link
    Mannequin Author

    dabrahams mannequin commented May 8, 2010 

    from urlparse import *
urlunsplit(urlsplit('git+file:///foo/bar/baz'))
=> git+file:/foo/bar/baz

    @orsenthil orsenthil self-assigned this May 8, 2010
    @orsenthil orsenthil added the type-bug An unexpected behavior, bug, or error label May 8, 2010
    @meatballhat
    Copy link
    Mannequin

    meatballhat mannequin commented May 8, 2010

    Is simply adding 'git+' entries comprehensive enough? I'd have said the same thing about the addition of the 'svn+' entries, fwiw :) Is adding hardcoded entries like this the preferred way to extend urlparse?

    @orsenthil
    Copy link
    Member

    I have added 'git' and 'git+ssh' under known schemes which will recognize authority/netloc and follow consistent round trip parsing behaviors.

    For any unknown scheme(x or git+file), it might required to update the uses_netloc in the application.

    git+ and svn+ might not be a good idea, as git+foobar like terms might cause ambiguity.

    Fixed in r81130, r81131, r81132 and r81133.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    tony added a commit to tony/pip that referenced this issue Jun 25, 2022
    @tony
    vcs(git): Remove redundant scheme for git+ssh
    24456d9 
    This has been in cpython since 2.7 / 3.1.

See also:
- python/cpython@ead169d
- https://bugs.python.org/issue8657 or
  python/cpython#52903 (comment)
    tony added a commit to vcs-python/libvcs that referenced this issue Jun 25, 2022
    @tony
    chore(git): Remove uses_netloc for git+ssh, already in cpython
    bf886bb 
    See also:
- python/cpython@ead169d
- https://bugs.python.org/issue8657 or
  python/cpython#52903 (comment)
    @tony tony mentioned this issue Jun 25, 2022
    Merged
    tony added a commit to vcs-python/libvcs that referenced this issue Jun 25, 2022
    @tony
    chore(git): Remove another already supported netloc scheme ('git')
    abde06a 
    See also:
- #378 (removes 'git+ssh')
- python/cpython@ead169d
- https://bugs.python.org/issue8657 or
  python/cpython#52903 (comment)
    This was referenced Jun 25, 2022
    Merged
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @orsenthil orsenthil

    Labels
    type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @orsenthil