classification
Title: urlparse.urlunsplit should be smarter about +
Type: behavior Stage: resolved
Components: Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: orsenthil Nosy List: dabrahams, meatballhat, orsenthil
Priority: normal Keywords: patch

Created on 2010-05-08 02:49 by dabrahams, last changed 2010-05-13 03:49 by orsenthil. This issue is now closed.

Files
File name Uploaded Description Edit
urlparse_giturl.patch orsenthil, 2010-05-08 04:07
Messages (3)
msg105253 - (view) Author: Dave Abrahams (dabrahams) Date: 2010-05-08 02:49
from urlparse import *
urlunsplit(urlsplit('git+file:///foo/bar/baz'))
=> git+file:/foo/bar/baz
msg105280 - (view) Author: Dan Buch (meatballhat) Date: 2010-05-08 11:16
Is simply adding 'git+' entries comprehensive enough?  I'd have said the same thing about the addition of the 'svn+' entries, fwiw :)  Is adding hardcoded entries like this the preferred way to extend urlparse?
msg105622 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2010-05-13 03:49
I have added 'git' and 'git+ssh' under known schemes which will recognize authority/netloc and follow consistent round trip parsing behaviors.

For any unknown scheme(x or git+file), it might required to update the uses_netloc in the application.

git+ and svn+ might not be a good idea, as git+foobar like terms might cause ambiguity.

Fixed in r81130, r81131, r81132 and r81133.
History
Date User Action Args
2010-05-13 03:49:07orsenthilsetstatus: open -> closed
resolution: accepted -> fixed
messages: + msg105622

stage: patch review -> resolved
2010-05-08 11:16:52meatballhatsetnosy: + meatballhat
messages: + msg105280
2010-05-08 04:07:53orsenthilsetfiles: + urlparse_giturl.patch
assignee: orsenthil

keywords: + patch
nosy: + orsenthil
type: behavior
resolution: accepted
stage: patch review
2010-05-08 02:49:07dabrahamscreate