Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a timeout in test_urllibnet #52745

Closed
vstinner opened this issue Apr 22, 2010 · 4 comments
Closed

Set a timeout in test_urllibnet #52745

vstinner opened this issue Apr 22, 2010 · 4 comments
Labels
stdlib Python modules in the Lib dir tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 8499
Nosy @orsenthil, @vstinner, @sandrotosi
Dependencies
  • bpo-8574: transient_internet() (test_support): use socket.setdefaulttimeout() and test_robotparser failure
    		•
    Files
  • test_urllibnet_transient_internet.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2011-01-05.17:55:40.983>
created_at = <Date 2010-04-22.14:56:10.755>
labels = ['tests', 'library']
title = 'Set a timeout in test_urllibnet'
updated_at = <Date 2011-01-05.17:55:40.981>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2011-01-05.17:55:40.981>
actor = 'sandro.tosi'
assignee = 'none'
closed = True
closed_date = <Date 2011-01-05.17:55:40.983>
closer = 'sandro.tosi'
components = ['Library (Lib)', 'Tests']
creation = <Date 2010-04-22.14:56:10.755>
creator = 'vstinner'
dependencies = ['8574']
files = ['17138']
hgrepos = []
issue_num = 8499
keywords = ['patch']
message_count = 4.0
messages = ['103971', '104598', '104601', '125441']
nosy_count = 3.0
nosy_names = ['orsenthil', 'vstinner', 'sandro.tosi']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue8499'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']
    @vstinner
    Copy link
    Member Author

    As bpo-8460 (test_urllib2net), test_urllibnet fails if a website doesn't answer. Today, it was www.python.org during few minutes:

    http://www.python.org/dev/buildbot/all/builders/amd64 gentoo 3.1/builds/482/steps/test/logs/stdio
    ---
    test_urllibnet
    test test_urllibnet failed -- multiple errors occurred; run in verbose mode for details
    ---
    (the test was executed again, but www.python.org was back)

    test_urllib should use a timeout, as done for test_urllib2: see bpo-8460.

    @vstinner vstinner added stdlib Python modules in the Lib dir tests Tests in the Lib/test dir labels Apr 22, 2010
    @vstinner
    Copy link
    Member Author

    See also issue bpo-8574.

    @vstinner
    Copy link
    Member Author

    Patch to use transient_internet() context manager: the patch requires transient_internet-xxx.patch of issue bpo-8574.

    @sandrotosi
    Copy link
    Contributor

    This was already fixed (in an unrelated commit) with r85630 and prevoious, so I'm marking this issue as closed.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir tests Tests in the Lib/test dir
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @sandrotosi