This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Set a timeout in test_urllibnet
Type: Stage:
Components: Library (Lib), Tests Versions: Python 3.1, Python 3.2, Python 2.7, Python 2.6
process
Status: closed Resolution: fixed
Dependencies: 8574 Superseder:
Assigned To: Nosy List: orsenthil, sandro.tosi, vstinner
Priority: normal Keywords: patch

Created on 2010-04-22 14:56 by vstinner, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
test_urllibnet_transient_internet.patch vstinner, 2010-04-30 00:19 review
Messages (4)
msg103971 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-22 14:56
As #8460 (test_urllib2net), test_urllibnet fails if a website doesn't answer. Today, it was www.python.org during few minutes:

http://www.python.org/dev/buildbot/all/builders/amd64 gentoo 3.1/builds/482/steps/test/logs/stdio
---
test_urllibnet
test test_urllibnet failed -- multiple errors occurred; run in verbose mode for details
---
(the test was executed again, but www.python.org was back)

test_urllib should use a timeout, as done for test_urllib2: see #8460.
msg104598 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-30 00:00
See also issue #8574.
msg104601 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-04-30 00:19
Patch to use transient_internet() context manager: the patch requires transient_internet-xxx.patch of issue #8574.
msg125441 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2011-01-05 17:55
This was already fixed (in an unrelated commit) with r85630 and prevoious, so I'm marking this issue as closed.
History
Date User Action Args
2022-04-11 14:57:00adminsetgithub: 52745
2011-01-05 17:55:40sandro.tosisetstatus: open -> closed

nosy: + sandro.tosi
messages: + msg125441

resolution: fixed
2010-04-30 00:19:31vstinnersetfiles: + test_urllibnet_transient_internet.patch
keywords: + patch
dependencies: + transient_internet() (test_support): use socket.setdefaulttimeout() and test_robotparser failure
messages: + msg104601
2010-04-30 00:00:20vstinnersetmessages: + msg104598
2010-04-22 14:56:10vstinnercreate