New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing dependency in distutils build #49493
Comments
When running the command install_lib, the command build_clib is not run. In real life you can see it when trying to run the command install_lib The patch provided needs do be applied in the distutils dir directly with patch install_lib.py dependency.patch As requested, I asked on the mailing list first, whether this really is I am half finished writing a test case, that I'll append to this ticket |
be careful to write your test in distutils (setuptools is not part of |
The attached test works breaks without the patch and passes with the patch. I am not sure whether the test itself is written following best practice. |
The patch looks good. Minor tweaks :
|
Thank you, tarek The sys.path should have been obvious. |
It looks like there's a missing part in the patch: get_outputs(), and Now something I don't understand is how reportlab distribution is doing Could you point me please to the package so I can test that ? Thanks ! |
Hi Tarek, I think clib stuff is installed in the right python directory and the To reproduce the issue, run I can also show it during Plone Conference, just look for me in irc. Thanks,
|
Adding back distutils1. This is a bug, not a feature. |
Has the patch been applied on distutils(1/2) ? |
If we haven’t closed it, it’s because it has not been. |
The patch is straightforward and the test looks good. However, I worry about backward compatibility. For projects without C libs, this won’t change anything; for projects already having a workaround, what will happen? While this is clearly a bug, I’m not sure fixing the existing behavior is okay in distutils. For packaging (distutils2), I will commit this shortly. |
|
This issue has been open for some time, looking at the install_lib in master, there have been no changes to call 'build_clib' so the issue documented here would still apply. |
Distutils is now deprecated (see PEP-632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils. If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: