msg81892 - (view) |
Author: Patrick Gerken (do3cc) |
Date: 2009-02-13 09:57 |
When running the command install_lib, the command build_clib is not run.
If a package contains clibs they can be dependencies for extension libs,
at least that is stated in the module docstring of build_clib.
In real life you can see it when trying to run the command install_lib
on the current reportlab2.3.
The patch provided needs do be applied in the distutils dir directly with
patch install_lib.py dependency.patch
As requested, I asked on the mailing list first, whether this really is
a bug.
http://mail.python.org/pipermail/distutils-sig/2009-February/010974.html
I am half finished writing a test case, that I'll append to this ticket
later.
|
msg81894 - (view) |
Author: Tarek Ziadé (tarek) * |
Date: 2009-02-13 10:02 |
be careful to write your test in distutils (setuptools is not part of
Python)
|
msg82187 - (view) |
Author: Patrick Gerken (do3cc) |
Date: 2009-02-15 23:52 |
The attached test works breaks without the patch and passes with the patch.
I am not sure whether the test itself is written following best practice.
I would be more than happy for a review, with hints what should be done
better.
|
msg82189 - (view) |
Author: Tarek Ziadé (tarek) * |
Date: 2009-02-16 00:00 |
The patch looks good.
Minor tweaks :
- sys.path should be set to its initial state after the test
(setUp/tearDown might be helpfull here)
- ensure_finalized() should be called right before run()
so it acts like the real call
|
msg82637 - (view) |
Author: Patrick Gerken (do3cc) |
Date: 2009-02-23 19:23 |
Thank you, tarek
The sys.path should have been obvious.
|
msg94078 - (view) |
Author: Tarek Ziadé (tarek) * |
Date: 2009-10-15 08:23 |
It looks like there's a missing part in the patch: get_outputs(), and
get_inputs() should also return files created in build()
Now something I don't understand is how reportlab distribution is doing
to copy the compiled extensions when "install" is called.
Could you point me please to the package so I can test that ?
Thanks !
|
msg94614 - (view) |
Author: Patrick Gerken (do3cc) |
Date: 2009-10-28 08:32 |
Hi Tarek,
I think clib stuff is installed in the right python directory and the
ext install step then just finds them.
To reproduce the issue, run
the "old" easy_install in a virtualenv.
easy_install ReportLab
It will then fail because of the missing library.
I can also show it during Plone Conference, just look for me in irc.
Thanks,
Patrick
|
msg115784 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2010-09-07 15:55 |
Adding back distutils1. This is a bug, not a feature.
|
msg128497 - (view) |
Author: Alexis Metaireau (alexis) * |
Date: 2011-02-13 14:23 |
Has the patch been applied on distutils(1/2) ?
|
msg128510 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2011-02-13 15:41 |
If we haven’t closed it, it’s because it has not been.
|
msg138117 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2011-06-10 17:15 |
>> Now something I don't understand is how reportlab distribution is doing
>> to copy the compiled extensions when "install" is called.
> I think clib stuff is installed in the right python directory and the
> ext install step then just finds them.
Yep, the install* commands just copy all files from the build dir to the install dir.
The patch is straightforward and the test looks good. However, I worry about backward compatibility. For projects without C libs, this won’t change anything; for projects already having a workaround, what will happen? While this is clearly a bug, I’m not sure fixing the existing behavior is okay in distutils.
For packaging (distutils2), I will commit this shortly.
|
msg138205 - (view) |
Author: Éric Araujo (eric.araujo) * |
Date: 2011-06-12 11:06 |
> for projects already having a workaround, what will happen?
I think I have the answer to my question: if build_clib is called twice, the registry in Distribution will know that it has run and won’t run it again. I’ll test manually and if I confirm, I will commit this change.
|
msg341576 - (view) |
Author: anthony shaw (anthonypjshaw) * |
Date: 2019-05-06 17:44 |
This issue has been open for some time, looking at the install_lib in master, there have been no changes to call 'build_clib' so the issue documented here would still apply.
|
msg386291 - (view) |
Author: Steve Dower (steve.dower) * |
Date: 2021-02-03 18:11 |
Distutils is now deprecated (see PEP 632) and all tagged issues are being closed. From now until removal, only release blocking issues will be considered for distutils.
If this issue does not relate to distutils, please remove the component and reopen it. If you believe it still requires a fix, most likely the issue should be re-reported at https://github.com/pypa/setuptools
|
|
Date |
User |
Action |
Args |
2022-04-11 14:56:45 | admin | set | github: 49493 |
2021-02-03 18:11:00 | steve.dower | set | status: open -> closed
nosy:
+ steve.dower messages:
+ msg386291
resolution: out of date stage: patch review -> resolved |
2019-05-06 18:22:57 | anthonypjshaw | set | nosy:
+ ncoghlan, dstufft
|
2019-05-06 17:44:16 | anthonypjshaw | set | nosy:
+ anthonypjshaw messages:
+ msg341576
|
2014-03-13 03:58:32 | eric.araujo | set | components:
- Distutils2 versions:
+ Python 3.4, - 3rd party, Python 3.2 |
2011-06-12 11:06:27 | eric.araujo | set | assignee: tarek -> eric.araujo messages:
+ msg138205 |
2011-06-10 17:15:36 | eric.araujo | set | resolution: accepted -> (no value) stage: patch review messages:
+ msg138117 versions:
+ Python 3.3, - Python 3.1 |
2011-02-13 15:41:48 | eric.araujo | set | nosy:
tarek, eric.araujo, do3cc, alexis messages:
+ msg128510 |
2011-02-13 14:23:15 | alexis | set | nosy:
+ alexis messages:
+ msg128497
|
2010-09-29 23:43:03 | eric.araujo | set | versions:
+ 3rd party |
2010-09-07 15:55:53 | eric.araujo | set | messages:
+ msg115784 |
2010-09-07 15:54:49 | eric.araujo | set | nosy:
+ eric.araujo
components:
+ Distutils versions:
- Python 2.6, Python 2.5, Python 3.0, Python 3.3 |
2010-04-20 15:44:24 | eric.araujo | set | components:
+ Distutils2, - Distutils versions:
+ Python 2.5, Python 3.1, Python 3.3 |
2009-10-28 08:32:59 | do3cc | set | messages:
+ msg94614 |
2009-10-15 08:23:20 | tarek | set | priority: normal resolution: accepted messages:
+ msg94078
versions:
+ Python 3.0, Python 3.2, - Python 2.5, Python 2.4 |
2009-02-23 19:23:04 | do3cc | set | files:
+ test_install_lib.py messages:
+ msg82637 |
2009-02-16 00:00:26 | tarek | set | messages:
+ msg82189 |
2009-02-15 23:52:16 | do3cc | set | files:
+ test_install_lib.py messages:
+ msg82187 |
2009-02-13 10:02:23 | tarek | set | messages:
+ msg81894 |
2009-02-13 09:57:07 | do3cc | create | |