Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetBSD curses compatibility #90158

Closed
0-wiz-0 mannequin opened this issue Dec 6, 2021 · 7 comments
Closed

NetBSD curses compatibility #90158

0-wiz-0 mannequin opened this issue Dec 6, 2021 · 7 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@0-wiz-0
Copy link
Mannequin

0-wiz-0 mannequin commented Dec 6, 2021

BPO 46000
Nosy @tiran, @0-wiz-0, @serhiy-storchaka, @miss-islington
PRs
  • bpo-46000: improve NetBSD curses compatibility #29947
  • [3.10] bpo-46000: Improve NetBSD curses compatibility (GH-29947) #30022
  • [3.9] bpo-46000: Improve NetBSD curses compatibility (GH-29947) #30023
    		•
    Files
  • patch-Modules___cursesmodule.c: Patch fixing the problem
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-12-10.11:46:01.015>
created_at = <Date 2021-12-06.16:11:52.398>
labels = ['extension-modules', 'type-bug', '3.9', '3.10', '3.11']
title = 'NetBSD curses compatibility'
updated_at = <Date 2021-12-10.11:46:01.012>
user = 'https://github.com/0-wiz-0'

    bugs.python.org fields:

    activity = <Date 2021-12-10.11:46:01.012>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-10.11:46:01.015>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2021-12-06.16:11:52.398>
creator = 'wiz'
dependencies = []
files = ['50480']
hgrepos = []
issue_num = 46000
keywords = ['patch']
message_count = 7.0
messages = ['407825', '407863', '407865', '408183', '408187', '408190', '408194']
nosy_count = 5.0
nosy_names = ['christian.heimes', 'wiz', 'python-dev', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['29947', '30022', '30023']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46000'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented Dec 6, 2021

    The code in Modules/_cursesmodule.c has an assumption on ncurses.
    The attached simple patch fixes this and works with both NetBSD curses and ncurses.

    @0-wiz-0 0-wiz-0 mannequin added 3.10 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Dec 6, 2021
    @tiran
    Copy link
    Member

    tiran commented Dec 6, 2021

    Could you please open a pull request on GitHub? A PR will run our CI and our bots will verify that your changeset follows our guidelines.

    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented Dec 6, 2021

    Done: #29947

    @serhiy-storchaka
    Copy link
    Member

    New changeset 2fb797e by Thomas Klausner in branch 'main':
    bpo-46000: Improve NetBSD curses compatibility (GH-29947)
    2fb797e

    @miss-islington
    Copy link
    Contributor

    New changeset bb76410 by Miss Islington (bot) in branch '3.10':
    bpo-46000: Improve NetBSD curses compatibility (GH-29947)
    bb76410

    @serhiy-storchaka
    Copy link
    Member

    New changeset 040f9f9 by Miss Islington (bot) in branch '3.9':
    bpo-46000: Improve NetBSD curses compatibility (GH-29947) (GH-30023)
    040f9f9

    @serhiy-storchaka
    Copy link
    Member

    Thank you Thomas for your contribution.

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes 3.11 only security fixes labels Dec 10, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @tiran @serhiy-storchaka @miss-islington