This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: NetBSD curses compatibility
Type: behavior Stage: resolved
Components: Extension Modules Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, miss-islington, python-dev, serhiy.storchaka, wiz
Priority: normal Keywords: patch

Created on 2021-12-06 16:11 by wiz, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
patch-Modules___cursesmodule.c wiz, 2021-12-06 16:11 Patch fixing the problem
Pull Requests
URL Status Linked Edit
PR 29947 merged python-dev, 2021-12-06 21:24
PR 30022 merged miss-islington, 2021-12-10 09:41
PR 30023 merged miss-islington, 2021-12-10 09:41
Messages (7)
msg407825 - (view) Author: Thomas Klausner (wiz) * Date: 2021-12-06 16:11
The code in Modules/_cursesmodule.c has an assumption on ncurses.
The attached simple patch fixes this and works with both NetBSD curses and ncurses.
msg407863 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-06 21:17
Could you please open a pull request on GitHub? A PR will run our CI and our bots will verify that your changeset follows our guidelines.
msg407865 - (view) Author: Thomas Klausner (wiz) * Date: 2021-12-06 21:24
Done: https://github.com/python/cpython/pull/29947
msg408183 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-12-10 09:41
New changeset 2fb797e93c6bbd44dfcbe23f63acfa240a87e48a by Thomas Klausner in branch 'main':
bpo-46000: Improve NetBSD curses compatibility (GH-29947)
https://github.com/python/cpython/commit/2fb797e93c6bbd44dfcbe23f63acfa240a87e48a
msg408187 - (view) Author: miss-islington (miss-islington) Date: 2021-12-10 10:29
New changeset bb76410824e526ee075eac22812a577cca7583cf by Miss Islington (bot) in branch '3.10':
bpo-46000: Improve NetBSD curses compatibility (GH-29947)
https://github.com/python/cpython/commit/bb76410824e526ee075eac22812a577cca7583cf
msg408190 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-12-10 11:21
New changeset 040f9f9c48f4e74e851d850275aa9e050a04d0c6 by Miss Islington (bot) in branch '3.9':
bpo-46000: Improve NetBSD curses compatibility (GH-29947) (GH-30023)
https://github.com/python/cpython/commit/040f9f9c48f4e74e851d850275aa9e050a04d0c6
msg408194 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-12-10 11:46
Thank you Thomas for your contribution.
History
Date User Action Args
2022-04-11 14:59:53adminsetgithub: 90158
2021-12-10 11:46:01serhiy.storchakasetstatus: open -> closed
versions: + Python 3.9, Python 3.11
messages: + msg408194

resolution: fixed
stage: patch review -> resolved
2021-12-10 11:21:24serhiy.storchakasetmessages: + msg408190
2021-12-10 10:29:30miss-islingtonsetmessages: + msg408187
2021-12-10 09:41:58miss-islingtonsetpull_requests: + pull_request28247
2021-12-10 09:41:55miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request28246
2021-12-10 09:41:52serhiy.storchakasetmessages: + msg408183
2021-12-07 09:43:55serhiy.storchakasetnosy: + serhiy.storchaka
2021-12-06 21:24:30wizsetmessages: + msg407865
2021-12-06 21:24:09python-devsetkeywords: + patch
nosy: + python-dev

pull_requests: + pull_request28172
stage: patch review
2021-12-06 21:17:04christian.heimessetnosy: + christian.heimes
messages: + msg407863
2021-12-06 16:11:52wizcreate