Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tkinter tests with old Tk #90137

Closed
serhiy-storchaka opened this issue Dec 4, 2021 · 7 comments
Closed

Fix Tkinter tests with old Tk #90137

serhiy-storchaka opened this issue Dec 4, 2021 · 7 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

BPO 45979
Nosy @vstinner, @serhiy-storchaka, @miss-islington, @erlend-aasland, @E-Paine
PRs
  • bpo-45979: Fix Tkinter tests with old Tk #29913
  • bpo-45979: Fix Tkinter tests with old Tk #31938
  • [3.9] bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938) #31940
  • [3.10] bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938) #31939
  • [3.10] bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938) #31972
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-03-19.14:48:27.873>
created_at = <Date 2021-12-04.11:38:47.562>
labels = ['expert-tkinter', '3.9', '3.10', '3.11', 'type-feature', 'tests']
title = 'Fix Tkinter tests with old Tk'
updated_at = <Date 2022-03-19.14:48:27.872>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2022-03-19.14:48:27.872>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2022-03-19.14:48:27.873>
closer = 'serhiy.storchaka'
components = ['Tests', 'Tkinter']
creation = <Date 2021-12-04.11:38:47.562>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 45979
keywords = ['patch']
message_count = 7.0
messages = ['407661', '407700', '415224', '415354', '415390', '415485', '415492']
nosy_count = 5.0
nosy_names = ['vstinner', 'serhiy.storchaka', 'miss-islington', 'erlendaasland', 'epaine']
pr_nums = ['29913', '31938', '31940', '31939', '31972']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue45979'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @serhiy-storchaka
    Copy link
    Member Author

    Some recently added tests are not compatible with old Tk versions. I have build all 8.5 and 8.6 versions and build and test Tkinter against them. The proposed PR makes tests passes on Tk versions 8.5.4 to 8.5.19 and 8.6.0 to 8.6.12. There are some issues with running the pure Tk shell for versions < 8.5.4 so I skipped them.

    @serhiy-storchaka serhiy-storchaka added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement labels Dec 4, 2021
    @E-Paine
    Copy link
    Mannequin

    E-Paine mannequin commented Dec 5, 2021

    Is support for such old Tk versions useful? 8.5.4 was released in late 2008, and I highly doubt anyone would still be using it. IMO, 8.5.12 would be a good compromise, since we're giving support to a version more than 9 years old, but would simplify PR-29913 by removing several 8.5.x specific branches. (FYI, 8.5.12 was released on 2012-07-27 and 8.6.0 on 2012-12-20)

    @serhiy-storchaka
    Copy link
    Member Author

    It is a great idea. I have opened bpo-46996 for this.

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset dbbe4d2 by Serhiy Storchaka in branch 'main':
    bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
    dbbe4d2

    @miss-islington
    Copy link
    Contributor

    New changeset 612019e by Miss Islington (bot) in branch '3.9':
    bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
    612019e

    @vstinner
    Copy link
    Member

    Python 3.10 didn't get a fix? #31939 was closed, not merged.

    @miss-islington
    Copy link
    Contributor

    New changeset d27af88 by Miss Islington (bot) in branch '3.10':
    bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
    d27af88

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @serhiy-storchaka @miss-islington