This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Fix Tkinter tests with old Tk
Type: enhancement Stage: resolved
Components: Tests, Tkinter Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: epaine, erlendaasland, miss-islington, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2021-12-04 11:38 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29913 closed serhiy.storchaka, 2021-12-04 11:42
PR 31938 merged serhiy.storchaka, 2022-03-16 16:44
PR 31940 merged miss-islington, 2022-03-16 18:41
PR 31939 closed miss-islington, 2022-03-16 18:49
PR 31972 merged miss-islington, 2022-03-18 12:18
Messages (7)
msg407661 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-12-04 11:38
Some recently added tests are not compatible with old Tk versions. I have build all 8.5 and 8.6 versions and build and test Tkinter against them. The proposed PR makes tests passes on Tk versions 8.5.4 to 8.5.19 and 8.6.0 to 8.6.12. There are some issues with running the pure Tk shell for versions < 8.5.4 so I skipped them.
msg407700 - (view) Author: E. Paine (epaine) * Date: 2021-12-05 09:52
Is support for such old Tk versions useful? 8.5.4 was released in late 2008, and I highly doubt anyone would still be using it. IMO, 8.5.12 would be a good compromise, since we're giving support to a version more than 9 years old, but would simplify PR-29913 by removing several 8.5.x specific branches. (FYI, 8.5.12 was released on 2012-07-27 and 8.6.0 on 2012-12-20)
msg415224 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2022-03-15 08:03
It is a great idea. I have opened issue46996 for this.
msg415354 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2022-03-16 17:39
New changeset dbbe4d2d0075fa0e95b069fb4780d79aae3514c7 by Serhiy Storchaka in branch 'main':
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
https://github.com/python/cpython/commit/dbbe4d2d0075fa0e95b069fb4780d79aae3514c7
msg415390 - (view) Author: miss-islington (miss-islington) Date: 2022-03-17 07:29
New changeset 612019e60e3a5340542122dabbc7ce5a27a8c635 by Miss Islington (bot) in branch '3.9':
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
https://github.com/python/cpython/commit/612019e60e3a5340542122dabbc7ce5a27a8c635
msg415485 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2022-03-18 10:41
Python 3.10 didn't get a fix? https://github.com/python/cpython/pull/31939 was closed, not merged.
msg415492 - (view) Author: miss-islington (miss-islington) Date: 2022-03-18 12:45
New changeset d27af88c1bcf3c6c185f81218b7bf86b38128ea9 by Miss Islington (bot) in branch '3.10':
bpo-45979: Fix Tkinter tests with old Tk (>= 8.5.12) (GH-31938)
https://github.com/python/cpython/commit/d27af88c1bcf3c6c185f81218b7bf86b38128ea9
History
Date User Action Args
2022-04-11 14:59:53adminsetgithub: 90137
2022-03-19 14:48:27serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2022-03-18 12:45:01miss-islingtonsetmessages: + msg415492
2022-03-18 12:18:40miss-islingtonsetpull_requests: + pull_request30062
2022-03-18 10:41:20vstinnersetnosy: + vstinner
messages: + msg415485
2022-03-17 07:29:50miss-islingtonsetmessages: + msg415390
2022-03-16 18:49:01miss-islingtonsetpull_requests: + pull_request30032
2022-03-16 18:41:57miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request30030
2022-03-16 17:39:22serhiy.storchakasetmessages: + msg415354
2022-03-16 16:44:32serhiy.storchakasetpull_requests: + pull_request30029
2022-03-15 08:31:56erlendaaslandsetnosy: + erlendaasland
2022-03-15 08:03:26serhiy.storchakasetmessages: + msg415224
2021-12-05 09:52:08epainesetmessages: + msg407700
2021-12-04 11:43:43serhiy.storchakasetnosy: + epaine
2021-12-04 11:42:24serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request28138
2021-12-04 11:38:47serhiy.storchakacreate