Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove test_subprocess_wait_no_same_group from test_asyncio tests #89131

Closed
nightlark mannequin opened this issue Aug 21, 2021 · 5 comments
Closed

Fix/remove test_subprocess_wait_no_same_group from test_asyncio tests #89131

nightlark mannequin opened this issue Aug 21, 2021 · 5 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@nightlark
Copy link
Mannequin

nightlark mannequin commented Aug 21, 2021

BPO 44968
Nosy @rbtcollins, @ezio-melotti, @voidspace, @asvetlov, @serhiy-storchaka, @1st1, @miss-islington, @akulakov, @nightlark
PRs
  • bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio #27870
  • [3.10] bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870) #27877
  • [3.9] bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870) #27878
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-08-22.08:04:54.692>
created_at = <Date 2021-08-21.04:27:32.955>
labels = ['type-bug', '3.9', '3.10', '3.11', 'tests', 'expert-asyncio']
title = 'Fix/remove test_subprocess_wait_no_same_group from test_asyncio tests'
updated_at = <Date 2021-08-22.08:04:54.691>
user = 'https://github.com/nightlark'

    bugs.python.org fields:

    activity = <Date 2021-08-22.08:04:54.691>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-08-22.08:04:54.692>
closer = 'serhiy.storchaka'
components = ['Tests', 'asyncio']
creation = <Date 2021-08-21.04:27:32.955>
creator = 'rmast'
dependencies = []
files = []
hgrepos = []
issue_num = 44968
keywords = ['patch']
message_count = 5.0
messages = ['400018', '400042', '400043', '400044', '400056']
nosy_count = 9.0
nosy_names = ['rbcollins', 'ezio.melotti', 'michael.foord', 'asvetlov', 'serhiy.storchaka', 'yselivanov', 'miss-islington', 'andrei.avk', 'rmast']
pr_nums = ['27870', '27877', '27878']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue44968'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @nightlark
    Copy link
    Mannequin Author

    nightlark mannequin commented Aug 21, 2021

    A deprecation made in bpo-41322 uncovered issues with test_subprocess_wait_no_same_group in test_asyncio that seems to have been broken for some time.

    Reverting to a similar structure prior to the refactoring in 658103f using async/await avoids the deprecation error, though it still might not be running correctly.

    With the change I tried in 658103f there is a message about an unknown child process, which makes me think there could be some issues with the subprocess exiting prior to the refactoring ~8 years ago.

    @nightlark nightlark mannequin added 3.8 only security fixes 3.10 only security fixes 3.11 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir labels Aug 21, 2021
    @serhiy-storchaka serhiy-storchaka added topic-asyncio type-bug An unexpected behavior, bug, or error and removed 3.8 only security fixes labels Aug 21, 2021
    @serhiy-storchaka
    Copy link
    Member

    New changeset 585390f by Serhiy Storchaka in branch 'main':
    bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)
    585390f

    @miss-islington
    Copy link
    Contributor

    New changeset d5781e9 by Miss Islington (bot) in branch '3.9':
    bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)
    d5781e9

    @miss-islington
    Copy link
    Contributor

    New changeset 88a1920 by Miss Islington (bot) in branch '3.10':
    bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)
    88a1920

    @serhiy-storchaka
    Copy link
    Member

    Thank you for your report Ryan. Indeed, there was a bug introduced during refactoring (one unneeded "yield" was kept), and there was a bug before refactoring (the transport was not closed).

    I'll open a new issue about "Unknown child process pid".

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes tests Tests in the Lib/test dir topic-asyncio type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington