This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Fix/remove test_subprocess_wait_no_same_group from test_asyncio tests
Type: behavior Stage: resolved
Components: asyncio, Tests Versions: Python 3.11, Python 3.10, Python 3.9
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: andrei.avk, asvetlov, ezio.melotti, michael.foord, miss-islington, rbcollins, rmast, serhiy.storchaka, yselivanov
Priority: normal Keywords: patch

Created on 2021-08-21 04:27 by rmast, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 27870 merged serhiy.storchaka, 2021-08-21 06:18
PR 27877 merged miss-islington, 2021-08-21 20:09
PR 27878 merged miss-islington, 2021-08-21 20:09
Messages (5)
msg400018 - (view) Author: Ryan Mast (nightlark) (rmast) * Date: 2021-08-21 04:27
A deprecation made in bpo-41322 uncovered issues with test_subprocess_wait_no_same_group in test_asyncio that seems to have been broken for some time.

Reverting to a similar structure prior to the refactoring in using async/await avoids the deprecation error, though it still might not be running correctly.

With the change I tried in there is a message about an `unknown child process`, which makes me think there could be some issues with the subprocess exiting prior to the refactoring ~8 years ago.
msg400042 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-08-21 20:09
New changeset 585390fdd8661b4bc08bdfc27551292da9b4b9b8 by Serhiy Storchaka in branch 'main':
bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)
msg400043 - (view) Author: miss-islington (miss-islington) Date: 2021-08-21 20:29
New changeset d5781e973079a20b2370686d6e080316d6c9f90d by Miss Islington (bot) in branch '3.9':
bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)
msg400044 - (view) Author: miss-islington (miss-islington) Date: 2021-08-21 20:30
New changeset 88a1920c7b7b0fb73c4037b460c6a4a8c0aa10f0 by Miss Islington (bot) in branch '3.10':
bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio (GH-27870)
msg400056 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-08-22 08:04
Thank you for your report Ryan. Indeed, there was a bug introduced during refactoring (one unneeded "yield" was kept), and there was a bug before refactoring (the transport was not closed).

I'll open a new issue about "Unknown child process pid".
Date User Action Args
2022-04-11 14:59:49adminsetgithub: 89131
2021-08-22 08:04:54serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg400056

stage: patch review -> resolved
2021-08-21 20:30:16miss-islingtonsetmessages: + msg400044
2021-08-21 20:29:26miss-islingtonsetmessages: + msg400043
2021-08-21 20:09:21miss-islingtonsetpull_requests: + pull_request26333
2021-08-21 20:09:16miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request26332
2021-08-21 20:09:15serhiy.storchakasetmessages: + msg400042
2021-08-21 06:21:18serhiy.storchakasettype: behavior
components: + asyncio
versions: - Python 3.8
2021-08-21 06:18:54serhiy.storchakasetkeywords: + patch
nosy: + serhiy.storchaka

pull_requests: + pull_request26324
stage: patch review
2021-08-21 04:32:32andrei.avksetnosy: + andrei.avk
2021-08-21 04:27:32rmastcreate