Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make patchcheck" fails #88291

Closed
pitrou opened this issue May 13, 2021 · 4 comments
Closed

"make patchcheck" fails #88291

pitrou opened this issue May 13, 2021 · 4 comments
Assignees
@pitrou
Labels
3.9 only security fixes 3.10 only security fixes 3.11 only security fixes type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented May 13, 2021

BPO 44125
Nosy @pitrou, @miss-islington
PRs
  • bpo-44125: Fix "make patchcheck" on non-English locale #26102
  • [3.10] bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102) #26105
  • [3.9] bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102) #26106
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2021-05-13.18:42:50.969>
created_at = <Date 2021-05-13.17:21:56.566>
labels = ['type-bug', '3.9', '3.10', '3.11']
title = '"make patchcheck" fails'
updated_at = <Date 2021-05-13.18:42:50.969>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2021-05-13.18:42:50.969>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2021-05-13.18:42:50.969>
closer = 'pitrou'
components = ['Demos and Tools']
creation = <Date 2021-05-13.17:21:56.566>
creator = 'pitrou'
dependencies = []
files = []
hgrepos = []
issue_num = 44125
keywords = ['patch']
message_count = 4.0
messages = ['393591', '393592', '393597', '393600']
nosy_count = 2.0
nosy_names = ['pitrou', 'miss-islington']
pr_nums = ['26102', '26105', '26106']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue44125'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']
    @pitrou
    Copy link
    Member Author

    pitrou commented May 13, 2021 

    ./python ./Tools/scripts/patchcheck.py
Getting base branch for PR ... Traceback (most recent call last):
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 307, in <module>
    main()
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 267, in main
    base_branch = get_base_branch()
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 35, in call_fxn
    result = fxn(*args, **kwargs)
  File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 111, in get_base_branch
    return upstream_remote + "/" + base_branch
TypeError: can only concatenate str (not "NoneType") to str
make: *** [Makefile:2006 : patchcheck] Erreur 1

    @pitrou pitrou added 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels May 13, 2021
    @pitrou pitrou self-assigned this May 13, 2021
    @pitrou pitrou added type-bug An unexpected behavior, bug, or error 3.9 only security fixes 3.10 only security fixes 3.11 only security fixes labels May 13, 2021
    @pitrou pitrou self-assigned this May 13, 2021
    @pitrou pitrou added the type-bug An unexpected behavior, bug, or error label May 13, 2021
    @pitrou
    Copy link
    Member Author

    pitrou commented May 13, 2021

    The patch from bpo-44074 does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

    @miss-islington
    Copy link
    Contributor

    New changeset 04ce4c7 by Miss Islington (bot) in branch '3.9':
    bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102)
    04ce4c7

    @miss-islington
    Copy link
    Contributor

    New changeset 336dc52 by Miss Islington (bot) in branch '3.10':
    bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102)
    336dc52

    @pitrou pitrou closed this as completed May 13, 2021
    @pitrou pitrou closed this as completed May 13, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 only security fixes type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @pitrou @miss-islington