➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-05-13 17:21 by pitrou, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 26102 | merged | pitrou, 2021-05-13 17:24 | |
| PR 26105 | merged | miss-islington, 2021-05-13 17:48 | |
| PR 26106 | merged | miss-islington, 2021-05-13 17:48 | |
| Messages (4) | |||
|---|---|---|---|
| msg393591 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2021-05-13 17:21 | |
./python ./Tools/scripts/patchcheck.py
Getting base branch for PR ... Traceback (most recent call last):
File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 307, in <module>
main()
File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 267, in main
base_branch = get_base_branch()
File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 35, in call_fxn
result = fxn(*args, **kwargs)
File "/home/antoine/cpython/default/./Tools/scripts/patchcheck.py", line 111, in get_base_branch
return upstream_remote + "/" + base_branch
TypeError: can only concatenate str (not "NoneType") to str
make: *** [Makefile:2006 : patchcheck] Erreur 1
|
|||
| msg393592 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2021-05-13 17:22 | |
The patch from bpo-44074 does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text. |
|||
| msg393597 - (view) | Author: miss-islington (miss-islington) | Date: 2021-05-13 18:14 | |
New changeset 04ce4c773667b0d9d05a89aea4720f8cf84e834e by Miss Islington (bot) in branch '3.9': bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102) https://github.com/python/cpython/commit/04ce4c773667b0d9d05a89aea4720f8cf84e834e |
|||
| msg393600 - (view) | Author: miss-islington (miss-islington) | Date: 2021-05-13 18:42 | |
New changeset 336dc523a4180f99955b0fdb65e86059a1abac32 by Miss Islington (bot) in branch '3.10': bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102) https://github.com/python/cpython/commit/336dc523a4180f99955b0fdb65e86059a1abac32 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:45 | admin | set | github: 88291 |
| 2021-05-13 18:42:50 | pitrou | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-05-13 18:42:40 | miss-islington | set | messages: + msg393600 |
| 2021-05-13 18:14:30 | miss-islington | set | messages: + msg393597 |
| 2021-05-13 17:48:35 | miss-islington | set | pull_requests: + pull_request24749 |
| 2021-05-13 17:48:29 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request24747 |
| 2021-05-13 17:24:48 | pitrou | set | keywords:
+ patch stage: needs patch -> patch review pull_requests: + pull_request24743 |
| 2021-05-13 17:22:44 | pitrou | set | messages: + msg393592 |
| 2021-05-13 17:21:56 | pitrou | create | |