Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port ssl module to heap types and module state (PEP 573) #86499

Closed
tiran opened this issue Nov 12, 2020 · 5 comments
Closed

Port ssl module to heap types and module state (PEP 573) #86499

tiran opened this issue Nov 12, 2020 · 5 comments
Labels
3.10 only security fixes type-feature A feature request or enhancement

Comments

@tiran
Copy link
Member

tiran commented Nov 12, 2020

BPO 42333
Nosy @vstinner, @tiran, @shihai1991, @wingel
PRs
  • bpo-42333: Port _ssl extension to multiphase initialization (PEP 489) (GH-23253) #23253
  • bpo-42333: Port _ssl extension module to heap types (GH-23392) #23392
  • bpo-37952: SSL: add support for export_keying_material #25255
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2021-04-17.18:08:05.457>
created_at = <Date 2020-11-12.17:19:18.427>
labels = ['type-feature', '3.10']
title = 'Port ssl module to heap types and module state (PEP 573)'
updated_at = <Date 2021-04-22.09:41:31.576>
user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-04-22.09:41:31.576>
actor = 'wingel71'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-17.18:08:05.457>
closer = 'christian.heimes'
components = []
creation = <Date 2020-11-12.17:19:18.427>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 42333
keywords = ['patch']
message_count = 5.0
messages = ['380837', '380856', '381419', '381467', '391293']
nosy_count = 4.0
nosy_names = ['vstinner', 'christian.heimes', 'shihai1991', 'wingel71']
pr_nums = ['23253', '23392', '25255']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue42333'
versions = ['Python 3.10']
    @tiran
    Copy link
    Member Author

    tiran commented Nov 12, 2020

    Move all objects to module state. Convert all types and extensions to heap types.

    @tiran tiran added 3.10 only security fixes type-feature A feature request or enhancement labels Nov 12, 2020
    @tiran
    Copy link
    Member Author

    tiran commented Nov 12, 2020

    I underestimated the effort but it's done:

    +567 −446
    1,013 lines changed

    I even got rid of PyState_FindModule().

    @vstinner
    Copy link
    Member

    I marked bpo-15670 as duplicate of this issue.

    @tiran
    Copy link
    Member Author

    tiran commented Nov 20, 2020

    New changeset 5c36da7 by Christian Heimes in branch 'master':
    bpo-42333: Port _ssl extension module to heap types (GH-23392)
    5c36da7

    @tiran
    Copy link
    Member Author

    tiran commented Apr 17, 2021

    New changeset 7f1305e by Christian Heimes in branch 'master':
    bpo-42333: Port _ssl extension to multiphase initialization (PEP-489) (GH-23253)
    7f1305e

    @tiran tiran closed this as completed Apr 17, 2021
    @tiran tiran closed this as completed Apr 17, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.10 only security fixes type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @tiran