Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_dirnameW is used outside HAVE_SYMLINK #84833

Closed
gongminmin mannequin opened this issue May 17, 2020 · 5 comments
Closed

_dirnameW is used outside HAVE_SYMLINK #84833

gongminmin mannequin opened this issue May 17, 2020 · 5 comments
Labels
3.8 only security fixes build The build process and cross-build OS-windows

Comments

@gongminmin
Copy link
Mannequin

gongminmin mannequin commented May 17, 2020

BPO 40653
Nosy @pfmoore, @tjguk, @zware, @gongminmin, @zooba, @miss-islington
PRs
  • bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif #20144
  • [3.8] bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144) #20185
  • [3.7] bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144) #20186
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-05-18.16:18:07.258>
created_at = <Date 2020-05-17.03:05:19.654>
labels = ['build', '3.8', 'OS-windows']
title = '_dirnameW is used outside HAVE_SYMLINK'
updated_at = <Date 2020-05-18.16:36:09.602>
user = 'https://github.com/gongminmin'

    bugs.python.org fields:

    activity = <Date 2020-05-18.16:36:09.602>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-18.16:18:07.258>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2020-05-17.03:05:19.654>
creator = 'Minmin.Gong'
dependencies = []
files = []
hgrepos = []
issue_num = 40653
keywords = ['patch']
message_count = 5.0
messages = ['369089', '369262', '369264', '369270', '369271']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'Minmin.Gong', 'steve.dower', 'miss-islington']
pr_nums = ['20144', '20185', '20186']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue40653'
versions = ['Python 3.8']
    @gongminmin
    Copy link
    Mannequin Author

    gongminmin mannequin commented May 17, 2020

    _dirnameW is defined inside #ifdef HAVE_SYMLINK/#endif, but it's used in os__getdiskusage_impl, which is outside HAVE_SYMLINK. So if HAVE_SYMLINK is not defined (e.g., on UWP), it'll have compiling issues.

    @gongminmin gongminmin mannequin added 3.8 only security fixes OS-windows build The build process and cross-build labels May 17, 2020
    @zooba
    Copy link
    Member

    zooba commented May 18, 2020

    New changeset 7f21c9a by Minmin Gong in branch 'master':
    bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif (GH-20144)
    7f21c9a

    @zooba
    Copy link
    Member

    zooba commented May 18, 2020

    Thanks! Nice catch.

    Closing this, but I'll keep an eye on the backports.

    @zooba zooba closed this as completed May 18, 2020
    @zooba zooba closed this as completed May 18, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 6da26f8 by Miss Islington (bot) in branch '3.7':
    bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144)
    6da26f8

    @miss-islington
    Copy link
    Contributor

    New changeset ddd5bbd by Miss Islington (bot) in branch '3.8':
    bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144)
    ddd5bbd

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington