classification
Title: _dirnameW is used outside HAVE_SYMLINK
Type: compile error Stage: resolved
Components: Windows Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Minmin.Gong, miss-islington, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2020-05-17 03:05 by Minmin.Gong, last changed 2020-05-18 16:36 by miss-islington. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20144 merged Minmin.Gong, 2020-05-17 03:06
PR 20185 merged miss-islington, 2020-05-18 16:17
PR 20186 merged miss-islington, 2020-05-18 16:17
Messages (5)
msg369089 - (view) Author: Minmin Gong (Minmin.Gong) * Date: 2020-05-17 03:05
_dirnameW is defined inside #ifdef HAVE_SYMLINK/#endif, but it's used in os__getdiskusage_impl, which is outside HAVE_SYMLINK. So if HAVE_SYMLINK is not defined (e.g., on UWP), it'll have compiling issues.
msg369262 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-05-18 16:17
New changeset 7f21c9ac872acc2114aee3313d132b016550ff42 by Minmin Gong in branch 'master':
bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif (GH-20144)
https://github.com/python/cpython/commit/7f21c9ac872acc2114aee3313d132b016550ff42
msg369264 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-05-18 16:18
Thanks! Nice catch.

Closing this, but I'll keep an eye on the backports.
msg369270 - (view) Author: miss-islington (miss-islington) Date: 2020-05-18 16:34
New changeset 6da26f8cec5c3f012e2fd001042ccadcd8aba640 by Miss Islington (bot) in branch '3.7':
bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144)
https://github.com/python/cpython/commit/6da26f8cec5c3f012e2fd001042ccadcd8aba640
msg369271 - (view) Author: miss-islington (miss-islington) Date: 2020-05-18 16:36
New changeset ddd5bbdeec8cf18ef074b3506c96d22ac3dc1f93 by Miss Islington (bot) in branch '3.8':
bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144)
https://github.com/python/cpython/commit/ddd5bbdeec8cf18ef074b3506c96d22ac3dc1f93
History
Date User Action Args
2020-05-18 16:36:09miss-islingtonsetmessages: + msg369271
2020-05-18 16:34:28miss-islingtonsetmessages: + msg369270
2020-05-18 16:18:07steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg369264

stage: patch review -> resolved
2020-05-18 16:17:44miss-islingtonsetpull_requests: + pull_request19487
2020-05-18 16:17:36miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request19486
2020-05-18 16:17:23steve.dowersetmessages: + msg369262
2020-05-17 03:06:25Minmin.Gongsetkeywords: + patch
stage: patch review
pull_requests: + pull_request19449
2020-05-17 03:05:19Minmin.Gongcreate