Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_msgid fail on FreeBSD 12.1-RELEASE-p1 with different domains #83974

Closed
isidentical opened this issue Feb 29, 2020 · 6 comments
Closed

make_msgid fail on FreeBSD 12.1-RELEASE-p1 with different domains #83974

isidentical opened this issue Feb 29, 2020 · 6 comments
Labels
3.9 only security fixes topic-email

Comments

@isidentical
Copy link
Sponsor Member

BPO 39793
Nosy @warsaw, @akuchling, @bitdancer, @miss-islington, @isidentical
PRs
  • bpo-39793: use the same domain on make_msgid tests #18698
  • [3.8] bpo-39793: use the same domain on make_msgid tests (GH-18698) #19554
  • [3.7] bpo-39793: use the same domain on make_msgid tests (GH-18698) #19555
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-04-16.23:09:35.976>
    created_at = <Date 2020-02-29.09:56:17.070>
    labels = ['expert-email', '3.9']
    title = 'make_msgid fail on FreeBSD 12.1-RELEASE-p1 with different domains'
    updated_at = <Date 2020-04-16.23:09:35.975>
    user = 'https://github.com/isidentical'

    bugs.python.org fields:

    activity = <Date 2020-04-16.23:09:35.975>
    actor = 'BTaskaya'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-04-16.23:09:35.976>
    closer = 'BTaskaya'
    components = ['email']
    creation = <Date 2020-02-29.09:56:17.070>
    creator = 'BTaskaya'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39793
    keywords = ['patch']
    message_count = 6.0
    messages = ['362969', '362990', '362994', '366612', '366617', '366618']
    nosy_count = 5.0
    nosy_names = ['barry', 'akuchling', 'r.david.murray', 'miss-islington', 'BTaskaya']
    pr_nums = ['18698', '19554', '19555']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue39793'
    versions = ['Python 3.9']

    @isidentical
    Copy link
    Sponsor Member Author

    $ ./python -m test test_email
    0:00:00 load avg: 0.25 Run tests sequentially
    0:00:00 load avg: 0.25 [1/1] test_email
    test test_email failed -- Traceback (most recent call last):
      File "/usr/home/isidentical/cpython/Lib/test/test_email/test_email.py", line 3345, in test_make_msgid_default_domain
        self.assertTrue(
    AssertionError: False is not true

    test_email failed

    == Tests result: FAILURE ==

    1 test failed:
    test_email

    Total duration: 9.5 sec
    Tests result: FAILURE

    >>> socket.getfqdn()
    'xxx.com'
    >>> socket.getfqdn()
    'yyy.org'
    >>> socket.getfqdn()
    'xxx.com'
    >>> socket.getfqdn()
    'xxx.yyy.com'

    @isidentical isidentical added 3.9 only security fixes topic-email labels Feb 29, 2020
    @bitdancer
    Copy link
    Member

    I don't object to this patch, but that sure looks like a broken system.

    @isidentical
    Copy link
    Sponsor Member Author

    but that sure looks like a broken system.

    These are all aliases to the same name.

    @akuchling
    Copy link
    Member

    New changeset 5565c30 by Batuhan Taşkaya in branch 'master':
    bpo-39793: use the same domain on make_msgid tests (bpo-18698)
    5565c30

    @akuchling
    Copy link
    Member

    New changeset ccf30e9 by Miss Islington (bot) in branch '3.8':
    bpo-39793: use the same domain on make_msgid tests (GH-18698) (GH-19554)
    ccf30e9

    @akuchling
    Copy link
    Member

    New changeset cd09d7e by Miss Islington (bot) in branch '3.7':
    bpo-39793: use the same domain on make_msgid tests (GH-18698) (GH-19555)
    cd09d7e

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes topic-email
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants