classification
Title: make_msgid fail on FreeBSD 12.1-RELEASE-p1 with different domains
Type: Stage: resolved
Components: email Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, akuchling, barry, miss-islington, r.david.murray
Priority: normal Keywords: patch

Created on 2020-02-29 09:56 by BTaskaya, last changed 2020-04-16 23:09 by BTaskaya. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18698 merged BTaskaya, 2020-02-29 09:59
PR 19554 merged miss-islington, 2020-04-16 17:29
PR 19555 merged miss-islington, 2020-04-16 17:29
Messages (6)
msg362969 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python triager) Date: 2020-02-29 09:56
$ ./python -m test test_email
0:00:00 load avg: 0.25 Run tests sequentially
0:00:00 load avg: 0.25 [1/1] test_email
test test_email failed -- Traceback (most recent call last):
  File "/usr/home/isidentical/cpython/Lib/test/test_email/test_email.py", line 3345, in test_make_msgid_default_domain
    self.assertTrue(
AssertionError: False is not true

test_email failed

== Tests result: FAILURE ==

1 test failed:
    test_email

Total duration: 9.5 sec
Tests result: FAILURE

>>> socket.getfqdn()
'xxx.com'
>>> socket.getfqdn()
'yyy.org'
>>> socket.getfqdn()
'xxx.com'
>>> socket.getfqdn()
'xxx.yyy.com'
msg362990 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2020-02-29 16:40
I don't object to this patch, but that sure looks like a broken system.
msg362994 - (view) Author: Batuhan Taskaya (BTaskaya) * (Python triager) Date: 2020-02-29 17:07
> but that sure looks like a broken system.

These are all aliases to the same name.
msg366612 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2020-04-16 17:29
New changeset 5565c30f0b25996a0e73477fc0e1e1aced52b926 by Batuhan Ta┼čkaya in branch 'master':
bpo-39793: use the same domain on make_msgid tests (#18698)
https://github.com/python/cpython/commit/5565c30f0b25996a0e73477fc0e1e1aced52b926
msg366617 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2020-04-16 18:08
New changeset ccf30e96d4bdcf04396e00899a0319041144509f by Miss Islington (bot) in branch '3.8':
bpo-39793: use the same domain on make_msgid tests (GH-18698) (GH-19554)
https://github.com/python/cpython/commit/ccf30e96d4bdcf04396e00899a0319041144509f
msg366618 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2020-04-16 18:09
New changeset cd09d7e55d160edc454763d3fb6a48180988741a by Miss Islington (bot) in branch '3.7':
bpo-39793: use the same domain on make_msgid tests (GH-18698) (GH-19555)
https://github.com/python/cpython/commit/cd09d7e55d160edc454763d3fb6a48180988741a
History
Date User Action Args
2020-04-16 23:09:35BTaskayasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-04-16 18:09:03akuchlingsetmessages: + msg366618
2020-04-16 18:08:03akuchlingsetmessages: + msg366617
2020-04-16 17:29:41miss-islingtonsetpull_requests: + pull_request18901
2020-04-16 17:29:34miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request18900
2020-04-16 17:29:18akuchlingsetnosy: + akuchling
messages: + msg366612
2020-02-29 17:07:15BTaskayasetmessages: + msg362994
2020-02-29 16:40:36r.david.murraysetmessages: + msg362990
2020-02-29 09:59:53BTaskayasetkeywords: + patch
stage: patch review
pull_requests: + pull_request18059
2020-02-29 09:56:17BTaskayacreate