Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some CIs silence potentially useful output from make #83880

Closed
ammaraskar opened this issue Feb 20, 2020 · 12 comments
Closed

Some CIs silence potentially useful output from make #83880

ammaraskar opened this issue Feb 20, 2020 · 12 comments
Labels
build The build process and cross-build type-feature A feature request or enhancement

Comments

@ammaraskar
Copy link
Member

BPO 39699
Nosy @mdickinson, @zooba, @ammaraskar
PRs
  • bpo-39699: Don't silence make on Azure and Github CIs #18583
  • [3.8] bpo-39699: Don't silence make on Azure and Github CIs (GH-18583) #18670
  • [3.7] bpo-39699: Don't silence make on Azure and Github CIs (GH-18583) #18671
  • [3.8] bpo-39699: Remove accidentally commited test change #21089
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-02-26.23:56:38.399>
created_at = <Date 2020-02-20.12:23:26.942>
labels = ['type-feature', 'build']
title = 'Some CIs silence potentially useful output from make'
updated_at = <Date 2020-06-23.18:28:33.076>
user = 'https://github.com/ammaraskar'

    bugs.python.org fields:

    activity = <Date 2020-06-23.18:28:33.076>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2020-02-26.23:56:38.399>
closer = 'steve.dower'
components = ['Build']
creation = <Date 2020-02-20.12:23:26.942>
creator = 'ammar2'
dependencies = []
files = []
hgrepos = []
issue_num = 39699
keywords = ['patch']
message_count = 12.0
messages = ['362316', '362319', '362354', '362361', '362719', '362725', '362745', '362755', '372172', '372187', '372188', '372190']
nosy_count = 3.0
nosy_names = ['mark.dickinson', 'steve.dower', 'ammar2']
pr_nums = ['18583', '18670', '18671', '21089']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39699'
versions = []
    @ammaraskar
    Copy link
    Member Author

    I think the Github action for building CPython on Ubuntu is accidentally caching the built Python files.

    If we take a look at: https://github.com/python/cpython/runs/455936632#step:7:1
    and
    https://github.com/python/cpython/pull/18567/checks?check_run_id=457662461#step:8:1

    It seems like it's running way too fast (and producing too little output) to actually be building all of CPython.

    Adding Steve who originally authored the action to the nosy list to see if they might have any insight.

    @ammaraskar ammaraskar added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels Feb 20, 2020
    @zooba
    Copy link
    Member

    zooba commented Feb 20, 2020

    46s seems okay to me, especially since the 23s for autoconf is separate.

    Try introducing a warning/error into the source code and see if it breaks.

    @ammaraskar
    Copy link
    Member Author

    Aah sorry. This was my mistake, I didn't notice that we're passing -s (silent) to make. It is actually performing the build underneath, just not with the outputs that get produced form other CIs.

    Steve, is there a reason the Github action and Azure pipelines:

    both pass -s to make but Travis doesn't? It seems like it might potentially hide useful information about the build.

    @zooba
    Copy link
    Member

    zooba commented Feb 20, 2020

    Probably just where I copied it from. PRs welcome!

    @ammaraskar ammaraskar reopened this Feb 20, 2020
    @ammaraskar ammaraskar changed the title Ubuntu Github action not fully running build process Some CIs silence potentially useful output from make Feb 20, 2020
    @ammaraskar ammaraskar added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error labels Feb 20, 2020
    @ammaraskar ammaraskar reopened this Feb 20, 2020
    @ammaraskar ammaraskar changed the title Ubuntu Github action not fully running build process Some CIs silence potentially useful output from make Feb 20, 2020
    @ammaraskar ammaraskar added type-feature A feature request or enhancement and removed type-bug An unexpected behavior, bug, or error labels Feb 20, 2020
    @zooba
    Copy link
    Member

    zooba commented Feb 26, 2020

    New changeset 6aa1f1e by Ammar Askar in branch 'master':
    bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
    6aa1f1e

    @zooba
    Copy link
    Member

    zooba commented Feb 26, 2020

    New changeset 343bc06 by Steve Dower in branch '3.8':
    bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
    343bc06

    @zooba
    Copy link
    Member

    zooba commented Feb 26, 2020

    New changeset 3bf9de2 by Steve Dower in branch '3.7':
    bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
    3bf9de2

    @zooba
    Copy link
    Member

    zooba commented Feb 26, 2020

    Had to disable the doctests in the 3.7 branch because I just couldn't get them passing. Pablo did the work for 3.8 and later though, so they're on for those.

    @zooba zooba closed this as completed Feb 26, 2020
    @zooba zooba closed this as completed Feb 26, 2020
    @mdickinson
    Copy link
    Member

    The text "TEST CHANGE TO BE UNDONE" is currently visible here: https://docs.python.org/3/whatsnew/3.0.html

    It was introduced in commit 343bc06.

    Should this test change have been undone?

    @ammaraskar
    Copy link
    Member Author

    Thanks for finding this Mark, looks like this was accidentally introduced in the 3.8 backport for testing the changes: #18670

    The master (6aa1f1e) and 3.7 (3bf9de2) commits look clean.

    @ammaraskar
    Copy link
    Member Author

    Opened up a quick pull request to fix it: #21089

    @zooba
    Copy link
    Member

    zooba commented Jun 23, 2020

    New changeset 6eab52f by Ammar Askar in branch '3.8':
    bpo-39699: Remove accidentally committed test change (GH-21089)
    6eab52f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    build The build process and cross-build type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @mdickinson @ammaraskar @zooba