This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Some CIs silence potentially useful output from make
Type: enhancement Stage: resolved
Components: Build Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ammar2, mark.dickinson, steve.dower
Priority: normal Keywords: patch

Created on 2020-02-20 12:23 by ammar2, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 18583 merged ammar2, 2020-02-20 23:34
PR 18670 merged steve.dower, 2020-02-26 19:31
PR 18671 merged steve.dower, 2020-02-26 19:31
PR 21089 merged ammar2, 2020-06-23 17:32
Messages (12)
msg362316 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2020-02-20 12:23
I think the Github action for building CPython on Ubuntu is accidentally caching the built Python files.

If we take a look at: https://github.com/python/cpython/runs/455936632#step:7:1
and
https://github.com/python/cpython/pull/18567/checks?check_run_id=457662461#step:8:1

It seems like it's running way too fast (and producing too little output) to actually be building all of CPython.

Adding Steve who originally authored the action to the nosy list to see if they might have any insight.
msg362319 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-02-20 14:11
46s seems okay to me, especially since the 23s for autoconf is separate.

Try introducing a warning/error into the source code and see if it breaks.
msg362354 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2020-02-20 22:04
Aah sorry. This was my mistake, I didn't notice that we're passing `-s` (silent) to make. It is actually performing the build underneath, just not with the outputs that get produced form other CIs.

Steve, is there a reason the Github action and Azure pipelines:

* https://github.com/python/cpython/blob/1246d892038a693304549f8574e6c2784b91589a/.azure-pipelines/posix-steps.yml#L23

* https://github.com/python/cpython/blob/1246d892038a693304549f8574e6c2784b91589a/.github/workflows/build.yml#L58

both pass `-s` to make but Travis doesn't? It seems like it might potentially hide useful information about the build.

* https://github.com/python/cpython/blob/1246d892038a693304549f8574e6c2784b91589a/.travis.yml#L170
msg362361 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-02-20 22:52
Probably just where I copied it from. PRs welcome!
msg362719 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-02-26 19:21
New changeset 6aa1f1ecf7142a4117eedb8c570f30da1598616c by Ammar Askar in branch 'master':
bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
https://github.com/python/cpython/commit/6aa1f1ecf7142a4117eedb8c570f30da1598616c
msg362725 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-02-26 19:57
New changeset 343bc06d8047e4a2e675394528dbb5155be1b3b5 by Steve Dower in branch '3.8':
bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
https://github.com/python/cpython/commit/343bc06d8047e4a2e675394528dbb5155be1b3b5
msg362745 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-02-26 22:08
New changeset 3bf9de2fb954bd1131f4f41517d7d5c316fb95f8 by Steve Dower in branch '3.7':
bpo-39699: Don't silence make on Azure and Github CIs (GH-18583)
https://github.com/python/cpython/commit/3bf9de2fb954bd1131f4f41517d7d5c316fb95f8
msg362755 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-02-26 23:56
Had to disable the doctests in the 3.7 branch because I just couldn't get them passing. Pablo did the work for 3.8 and later though, so they're on for those.
msg372172 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2020-06-23 13:58
The text "TEST CHANGE TO BE UNDONE" is currently visible here: https://docs.python.org/3/whatsnew/3.0.html

It was introduced in commit 343bc06d8047e4a2e675394528dbb5155be1b3b5.

Should this test change have been undone?
msg372187 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2020-06-23 17:35
Thanks for finding this Mark, looks like this was accidentally introduced in the 3.8 backport for testing the changes: https://github.com/python/cpython/pull/18670

The master (6aa1f1ecf7142a4117eedb8c570f30da1598616c) and 3.7 (3bf9de2fb954bd1131f4f41517d7d5c316fb95f8) commits look clean.
msg372188 - (view) Author: Ammar Askar (ammar2) * (Python committer) Date: 2020-06-23 17:41
Opened up a quick pull request to fix it: https://github.com/python/cpython/pull/21089
msg372190 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2020-06-23 18:28
New changeset 6eab52ffadb2836adb59d0578c84d247f05e19b1 by Ammar Askar in branch '3.8':
bpo-39699: Remove accidentally committed test change (GH-21089)
https://github.com/python/cpython/commit/6eab52ffadb2836adb59d0578c84d247f05e19b1
History
Date User Action Args
2022-04-11 14:59:26adminsetgithub: 83880
2020-06-23 18:28:33steve.dowersetmessages: + msg372190
2020-06-23 17:41:13ammar2setmessages: + msg372188
2020-06-23 17:35:55ammar2setmessages: + msg372187
2020-06-23 17:32:40ammar2setpull_requests: + pull_request20255
2020-06-23 13:58:55mark.dickinsonsetnosy: + mark.dickinson
messages: + msg372172
2020-02-26 23:56:38steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg362755

stage: patch review -> resolved
2020-02-26 22:08:14steve.dowersetmessages: + msg362745
2020-02-26 19:57:20steve.dowersetmessages: + msg362725
2020-02-26 19:31:23steve.dowersetpull_requests: + pull_request18027
2020-02-26 19:31:17steve.dowersetpull_requests: + pull_request18026
2020-02-26 19:21:47steve.dowersetmessages: + msg362719
2020-02-20 23:34:57ammar2setkeywords: + patch
stage: patch review
pull_requests: + pull_request17953
2020-02-20 23:33:57ammar2setstatus: closed -> open
resolution: not a bug -> (no value)
title: Ubuntu Github action not fully running build process -> Some CIs silence potentially useful output from make
type: behavior -> enhancement
stage: resolved -> (no value)
2020-02-20 22:52:00steve.dowersetmessages: + msg362361
2020-02-20 22:04:38ammar2setstatus: open -> closed
resolution: not a bug
messages: + msg362354

stage: resolved
2020-02-20 14:11:07steve.dowersetmessages: + msg362319
2020-02-20 12:23:26ammar2create