Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to "Python Packaging User Guide: Creating and using virtual environments" is broken #83598

Closed
angelcervera mannequin opened this issue Jan 22, 2020 · 10 comments
Closed

Link to "Python Packaging User Guide: Creating and using virtual environments" is broken #83598

angelcervera mannequin opened this issue Jan 22, 2020 · 10 comments
Labels
3.8 only security fixes docs Documentation in the Doc dir easy

Comments

@angelcervera
Copy link
Mannequin

angelcervera mannequin commented Jan 22, 2020

BPO 39417
Nosy @willingc, @ammaraskar, @Mariatta, @miss-islington, @nanjekyejoannah, @angelcervera, @j9ac9k
PRs
  • bpo-39417: Fix broken link to guide to building venvs #18432
  • [3.8] bpo-39417: Fix broken link to guide to building venvs (GH-18432) #21383
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-07-07.23:41:23.926>
created_at = <Date 2020-01-22.09:32:01.596>
labels = ['easy', '3.8', 'docs']
title = 'Link to "Python Packaging User Guide: Creating and using virtual environments" is broken'
updated_at = <Date 2020-07-07.23:47:12.394>
user = 'https://github.com/angelcervera'

    bugs.python.org fields:

    activity = <Date 2020-07-07.23:47:12.394>
actor = 'miss-islington'
assignee = 'docs@python'
closed = True
closed_date = <Date 2020-07-07.23:41:23.926>
closer = 'Mariatta'
components = ['Documentation']
creation = <Date 2020-01-22.09:32:01.596>
creator = 'angelcervera'
dependencies = []
files = []
hgrepos = []
issue_num = 39417
keywords = ['patch', 'newcomer friendly']
message_count = 10.0
messages = ['360454', '360455', '360456', '361713', '361714', '361754', '361822', '373243', '373266', '373268']
nosy_count = 8.0
nosy_names = ['docs@python', 'willingc', 'ammar2', 'Mariatta', 'miss-islington', 'nanjekyejoannah', 'angelcervera', 'Ognyan Moore']
pr_nums = ['18432', '21383']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue39417'
versions = ['Python 3.8']
    @angelcervera
    Copy link
    Mannequin Author

    angelcervera mannequin commented Jan 22, 2020

    The link "See also: Python Packaging User Guide: Creating and using virtual environments" Is broken.

    The problem is in line 30 of https://github.com/python/cpython/blob/3.8/Doc/library/venv.rst

    I don't know the right link, so I can not fix it.

    I any one provive me the right link, I can create a PR.

    @angelcervera angelcervera mannequin added the 3.8 only security fixes label Jan 22, 2020
    @angelcervera angelcervera mannequin assigned docspython Jan 22, 2020
    @angelcervera angelcervera mannequin added docs Documentation in the Doc dir 3.8 only security fixes labels Jan 22, 2020
    @angelcervera angelcervera mannequin assigned docspython Jan 22, 2020
    @angelcervera angelcervera mannequin added the docs Documentation in the Doc dir label Jan 22, 2020
    @ammaraskar
    Copy link
    Member

    Hi Angel, thank you for the report! The file that corresponds to that documentation is here https://github.com/python/cpython/blob/master/Doc/library/venv.rst and we'd be happy to have you make a PR for it :)

    @ammaraskar
    Copy link
    Member

    Oh and I think the new link should point here: https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/#creating-a-virtual-environment

    @j9ac9k
    Copy link
    Mannequin

    j9ac9k mannequin commented Feb 10, 2020

    Hi, I'm at pycascades cpython sprint, I can tackle this issue.

    @j9ac9k
    Copy link
    Mannequin

    j9ac9k mannequin commented Feb 10, 2020

    Submitted PR 18432 to reflect this fix

    @willingc
    Copy link
    Contributor

    New changeset c4a65ed by Ogi Moore in branch 'master':
    bpo-39417: Fix broken link to guide to building venvs (GH-18432)
    c4a65ed

    @angelcervera
    Copy link
    Mannequin Author

    angelcervera mannequin commented Feb 11, 2020

    Thanks for handling this. I'm sorry I didn't have a chance to create the
    pr. :(

    On Mon 10 Feb 2020, 23:51 Carol Willing, <report@bugs.python.org> wrote:

    Carol Willing <willingc@gmail.com> added the comment:

    New changeset c4a65ed by Ogi Moore in
    branch 'master':
    bpo-39417: Fix broken link to guide to building venvs (GH-18432)

    c4a65ed

    ----------
    nosy: +willingc

    Python tracker <report@bugs.python.org>
    <https://bugs.python.org/issue39417\>

    @nanjekyejoannah
    Copy link
    Member

    Looks like this should be closed as the submitted PR was merged. Just following up for consesus.

    @Mariatta
    Copy link
    Member

    Mariatta commented Jul 7, 2020

    Just needed a backport to 3.8 (which is in flight) so this is good to be closed.
    Thanks.

    @Mariatta Mariatta closed this as completed Jul 7, 2020
    @Mariatta Mariatta closed this as completed Jul 7, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 730bce3 by Miss Islington (bot) in branch '3.8':
    bpo-39417: Fix broken link to guide to building venvs (GH-18432)
    730bce3

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes docs Documentation in the Doc dir easy
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @ammaraskar @willingc @Mariatta @miss-islington @nanjekyejoannah