Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text divided in two strings due to wrong formatting #83364

Closed
rffontenelle mannequin opened this issue Jan 1, 2020 · 5 comments
Closed

Text divided in two strings due to wrong formatting #83364

rffontenelle mannequin opened this issue Jan 1, 2020 · 5 comments
Labels
3.9 only security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement

Comments

@rffontenelle
Copy link
Mannequin

rffontenelle mannequin commented Jan 1, 2020

BPO 39183
Nosy @miss-islington, @rffontenelle
PRs
  • bpo-39183: Fix formatting in library/ensurepip #17787
  • [3.8] bpo-39183: Fix formatting in library/ensurepip (GH-17787) #17788
  • [3.7] bpo-39183: Fix formatting in library/ensurepip (GH-17787) #17789
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-01-03.11:02:52.122>
    created_at = <Date 2020-01-01.22:06:36.434>
    labels = ['type-feature', '3.9', 'docs']
    title = 'Text divided in two strings due to wrong formatting'
    updated_at = <Date 2020-01-03.11:02:52.121>
    user = 'https://github.com/rffontenelle'

    bugs.python.org fields:

    activity = <Date 2020-01-03.11:02:52.121>
    actor = 'rffontenelle'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2020-01-03.11:02:52.122>
    closer = 'rffontenelle'
    components = ['Documentation']
    creation = <Date 2020-01-01.22:06:36.434>
    creator = 'rffontenelle'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39183
    keywords = ['patch']
    message_count = 5.0
    messages = ['359170', '359173', '359174', '359175', '359229']
    nosy_count = 3.0
    nosy_names = ['docs@python', 'miss-islington', 'rffontenelle']
    pr_nums = ['17787', '17788', '17789']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue39183'
    versions = ['Python 3.9']

    @rffontenelle
    Copy link
    Mannequin Author

    rffontenelle mannequin commented Jan 1, 2020

    When translating Python docs, the 'library/ensurepip' module [1] has an bullet list where one item's text is split in two due to a simple extra whitespace character. This causes two separated translations strings

    "--default-pip: if a "default pip" installation is requested, the"

    and

    "pip script will be installed in addition to the two regular scripts."

    , which clearly should be a single one.

    Its effect can be seen also in the resulting documentation, where these strings are shown in different lines even when there are enough space in the browser window to should it all.

    Solution is to remove the extra space and formatting is good again.

    [1] https://docs.python.org/3/library/ensurepip.html

    @rffontenelle rffontenelle mannequin added the 3.9 only security fixes label Jan 1, 2020
    @rffontenelle rffontenelle mannequin assigned docspython Jan 1, 2020
    @rffontenelle rffontenelle mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement 3.9 only security fixes labels Jan 1, 2020
    @rffontenelle rffontenelle mannequin assigned docspython Jan 1, 2020
    @rffontenelle rffontenelle mannequin added docs Documentation in the Doc dir type-feature A feature request or enhancement labels Jan 1, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset 149175c by Miss Islington (bot) (Rafael Fontenelle) in branch 'master':
    bpo-39183: Fix formatting in library/ensurepip (GH-17787)
    149175c

    @miss-islington
    Copy link
    Contributor

    New changeset 3959638 by Miss Islington (bot) in branch '3.7':
    bpo-39183: Fix formatting in library/ensurepip (GH-17787)
    3959638

    @miss-islington
    Copy link
    Contributor

    New changeset 6bf382a by Miss Islington (bot) in branch '3.8':
    bpo-39183: Fix formatting in library/ensurepip (GH-17787)
    6bf382a

    @rffontenelle
    Copy link
    Mannequin Author

    rffontenelle mannequin commented Jan 3, 2020

    Fix confirmed, closing.

    @rffontenelle rffontenelle mannequin closed this as completed Jan 3, 2020
    @rffontenelle rffontenelle mannequin closed this as completed Jan 3, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes docs Documentation in the Doc dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant