Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible leaks in PyArg_Parse for "es#" and "et#" #82721

Closed
serhiy-storchaka opened this issue Oct 21, 2019 · 6 comments
Closed

Possible leaks in PyArg_Parse for "es#" and "et#" #82721

serhiy-storchaka opened this issue Oct 21, 2019 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@serhiy-storchaka
Copy link
Member

BPO 38540
Nosy @methane, @serhiy-storchaka, @miss-islington
PRs
  • bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". #16869
  • [3.8] bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". (GH-16869) #16870
  • [3.7] bpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869) #16871
  • [3.7] bpo-38540: Revert a warning if PY_SSIZE_T_CLEAN is not defined. #16876
  • [2.7] bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". (GH-16869). #16877
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-10-21.20:52:04.673>
created_at = <Date 2019-10-21.06:20:29.976>
labels = ['interpreter-core', '3.7', '3.8', '3.9', 'performance']
title = 'Possible leaks in PyArg_Parse for "es#" and "et#"'
updated_at = <Date 2019-10-21.20:52:04.672>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2019-10-21.20:52:04.672>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2019-10-21.20:52:04.673>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2019-10-21.06:20:29.976>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 38540
keywords = ['patch']
message_count = 6.0
messages = ['355022', '355030', '355031', '355033', '355098', '355099']
nosy_count = 3.0
nosy_names = ['methane', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['16869', '16870', '16871', '16876', '16877']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue38540'
versions = ['Python 2.7', 'Python 3.7', 'Python 3.8', 'Python 3.9']
    @serhiy-storchaka
    Copy link
    Member Author

    There are possible leaks in PyArg_Parse and similar functions for format units "es#" and "et#". Macros STORE_SIZE and (since 3.8) FETCH_SIZE can leave the function despite there is an own reference to an encoded string (s). The leak is only possible when PY_SSIZE_T_CLEAN is not defined.

    @serhiy-storchaka serhiy-storchaka added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Oct 21, 2019
    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 5bc6a7c by Serhiy Storchaka in branch 'master':
    bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". (GH-16869)
    5bc6a7c

    @miss-islington
    Copy link
    Contributor

    New changeset 3dec84f by Miss Skeleton (bot) in branch '3.7':
    bpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869)
    3dec84f

    @miss-islington
    Copy link
    Contributor

    New changeset b1fc8c0 by Miss Skeleton (bot) in branch '3.8':
    bpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869)
    b1fc8c0

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset ccdfeb7 by Serhiy Storchaka in branch '2.7':
    [2.7] bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". (GH-16869). (GH-16877)
    ccdfeb7

    @serhiy-storchaka
    Copy link
    Member Author

    New changeset 928c68e by Serhiy Storchaka in branch '3.7':
    bpo-38540: Revert a warning if PY_SSIZE_T_CLEAN is not defined. (GH-16876)
    928c68e

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @serhiy-storchaka @miss-islington