classification
Title: Possible leaks in PyArg_Parse for "es#" and "et#"
Type: resource usage Stage: resolved
Components: Interpreter Core Versions: Python 3.9, Python 3.8, Python 3.7, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: inada.naoki, miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2019-10-21 06:20 by serhiy.storchaka, last changed 2019-10-21 20:52 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 16869 merged serhiy.storchaka, 2019-10-21 06:25
PR 16870 merged miss-islington, 2019-10-21 08:35
PR 16871 merged miss-islington, 2019-10-21 08:35
PR 16876 merged serhiy.storchaka, 2019-10-21 18:02
PR 16877 merged serhiy.storchaka, 2019-10-21 18:10
Messages (6)
msg355022 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-10-21 06:20
There are possible leaks in PyArg_Parse and similar functions for format units "es#" and "et#". Macros STORE_SIZE and (since 3.8) FETCH_SIZE can leave the function despite there is an own reference to an encoded string (s). The leak is only possible when PY_SSIZE_T_CLEAN is not defined.
msg355030 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-10-21 08:35
New changeset 5bc6a7c06eda20ba131ecba6752be0506d310181 by Serhiy Storchaka in branch 'master':
bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". (GH-16869)
https://github.com/python/cpython/commit/5bc6a7c06eda20ba131ecba6752be0506d310181
msg355031 - (view) Author: miss-islington (miss-islington) Date: 2019-10-21 08:56
New changeset 3dec84f40ef49bab994a1af4e6082bf81021feab by Miss Skeleton (bot) in branch '3.7':
bpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869)
https://github.com/python/cpython/commit/3dec84f40ef49bab994a1af4e6082bf81021feab
msg355033 - (view) Author: miss-islington (miss-islington) Date: 2019-10-21 09:12
New changeset b1fc8c0c8aec7ef8edd119034e076bc48882ffbb by Miss Skeleton (bot) in branch '3.8':
bpo-38540: Fix possible leak in PyArg_Parse for "esGH-" and "etGH-". (GH-16869)
https://github.com/python/cpython/commit/b1fc8c0c8aec7ef8edd119034e076bc48882ffbb
msg355098 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-10-21 18:40
New changeset ccdfeb7e969bf3aafd43dbe6581c30f66f2b0890 by Serhiy Storchaka in branch '2.7':
[2.7] bpo-38540: Fix possible leak in PyArg_Parse for "es#" and "et#". (GH-16869). (GH-16877)
https://github.com/python/cpython/commit/ccdfeb7e969bf3aafd43dbe6581c30f66f2b0890
msg355099 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2019-10-21 18:41
New changeset 928c68eee620cc6b624a195375143c2aa55644a4 by Serhiy Storchaka in branch '3.7':
bpo-38540: Revert a warning if PY_SSIZE_T_CLEAN is not defined. (GH-16876)
https://github.com/python/cpython/commit/928c68eee620cc6b624a195375143c2aa55644a4
History
Date User Action Args
2019-10-21 20:52:04serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-10-21 18:41:12serhiy.storchakasetmessages: + msg355099
2019-10-21 18:40:37serhiy.storchakasetmessages: + msg355098
2019-10-21 18:10:59serhiy.storchakasetpull_requests: + pull_request16422
2019-10-21 18:02:23serhiy.storchakasetpull_requests: + pull_request16421
2019-10-21 09:12:43miss-islingtonsetmessages: + msg355033
2019-10-21 08:56:53miss-islingtonsetnosy: + miss-islington
messages: + msg355031
2019-10-21 08:35:46miss-islingtonsetpull_requests: + pull_request16416
2019-10-21 08:35:39miss-islingtonsetpull_requests: + pull_request16415
2019-10-21 08:35:10serhiy.storchakasetmessages: + msg355030
2019-10-21 06:25:00serhiy.storchakasetkeywords: + patch
stage: patch review
pull_requests: + pull_request16414
2019-10-21 06:20:30serhiy.storchakacreate