Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tkinter CheckButton default label white in macOS dark mode #82442

Closed
RyangSohn mannequin opened this issue Sep 24, 2019 · 4 comments
Closed

Tkinter CheckButton default label white in macOS dark mode #82442

RyangSohn mannequin opened this issue Sep 24, 2019 · 4 comments
Assignees
@ned-deily
Labels
3.7 (EOL) end of life OS-mac topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@RyangSohn
Copy link
Mannequin

RyangSohn mannequin commented Sep 24, 2019

BPO 38261
Nosy @ronaldoussoren, @ned-deily
Superseder
  • bpo-42541: Tkinter colours wrong on MacOS universal2
    		•
    Files
  • tkinter_checkbox.py: The minimum source file to validate the issue.
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ned-deily'
closed_at = <Date 2020-12-03.15:57:12.304>
created_at = <Date 2019-09-24.04:35:40.355>
labels = ['OS-mac', 'type-bug', 'expert-tkinter', '3.7']
title = 'Tkinter CheckButton default label white in macOS dark mode'
updated_at = <Date 2020-12-03.15:57:12.303>
user = 'https://bugs.python.org/RyangSohn'

    bugs.python.org fields:

    activity = <Date 2020-12-03.15:57:12.303>
actor = 'ronaldoussoren'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2020-12-03.15:57:12.304>
closer = 'ronaldoussoren'
components = ['macOS', 'Tkinter']
creation = <Date 2019-09-24.04:35:40.355>
creator = 'Ryang Sohn'
dependencies = []
files = ['48620']
hgrepos = []
issue_num = 38261
keywords = []
message_count = 4.0
messages = ['353056', '353060', '381125', '382422']
nosy_count = 3.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'Ryang Sohn']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '42541'
type = 'behavior'
url = 'https://bugs.python.org/issue38261'
versions = ['Python 3.7']
    @RyangSohn
    Copy link
    Mannequin Author

    RyangSohn mannequin commented Sep 24, 2019

    In macOS, when "Dark Mode" is turned on, TKinter's checkbutton's default label color is white, not black.

    @RyangSohn RyangSohn mannequin added 3.7 (EOL) end of life OS-mac topic-tkinter type-bug An unexpected behavior, bug, or error labels Sep 24, 2019
    @ned-deily
    Copy link
    Member

    I assume you are using a Python 3.7.x from a python.org macOS installer? Support for macOS dark mode is almost entirely a Tk issue as Tkinter is basically a shallow wrapper around Tk-provided APIs. We have been shipping Tk 8.6.8, s stable, slightly out-of-date version because it seemed to have the least number of issues across all of the macOS versions we support. With macOS 10.15 coming soon, I will shortly be taking another look st the latest unreleased Tk which may also have better support for dark mode.

    @ned-deily ned-deily self-assigned this Sep 24, 2019
    @ronaldoussoren
    Copy link
    Contributor

    The same behaviour can be observed with Tk 8.6.10 build on macOS 11.

    IMHO the problem is not so much that the default text color changes, but that the background color of the window does not change, it stays the same light color as in light mode.

    According to the Tk wiki <https://wiki.tcl-lang.org/page/Tk+differences+on+Mac+OS+X\> the background color should adjust itself automatically. I don't know if Tkinter does something that affects this.

    @ronaldoussoren
    Copy link
    Contributor

    This is a duplicate of bpo-42541.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ned-deily ned-deily

    Labels
    3.7 (EOL) end of life OS-mac topic-tkinter type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @ronaldoussoren @ned-deily