Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

venv: Don't produce unbound variable warning on deactivate #82066

Closed
danabr mannequin opened this issue Aug 19, 2019 · 5 comments
Closed

venv: Don't produce unbound variable warning on deactivate #82066

danabr mannequin opened this issue Aug 19, 2019 · 5 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@danabr
Copy link
Mannequin

danabr mannequin commented Aug 19, 2019

BPO 37885
Nosy @Yhg1s, @danabr
PRs
  • bpo-37885: venv: Don't produce unbound variable warning on deactivate #15330
  • [3.8] bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330) #15973
  • [3.7] bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330) #15974
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-09-11.15:57:27.125>
created_at = <Date 2019-08-19.08:50:09.202>
labels = ['type-feature', 'library']
title = "venv: Don't produce unbound variable warning on deactivate"
updated_at = <Date 2019-09-11.15:57:27.124>
user = 'https://github.com/danabr'

    bugs.python.org fields:

    activity = <Date 2019-09-11.15:57:27.124>
actor = 'twouters'
assignee = 'none'
closed = True
closed_date = <Date 2019-09-11.15:57:27.125>
closer = 'twouters'
components = ['Library (Lib)']
creation = <Date 2019-08-19.08:50:09.202>
creator = 'danabr'
dependencies = []
files = []
hgrepos = []
issue_num = 37885
keywords = ['patch']
message_count = 5.0
messages = ['349944', '351918', '351955', '351957', '351958']
nosy_count = 2.0
nosy_names = ['twouters', 'danabr']
pr_nums = ['15330', '15973', '15974']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37885'
versions = []
    @danabr
    Copy link
    Mannequin Author

    danabr mannequin commented Aug 19, 2019

    Running deactivate from a bash shell configured to treat undefined variables as errors (set -u) produces a warning:

    $ python3 -m venv test
$ source test/bin/activate
(test) $ deactivate
-bash: $1: unbound variable

    @danabr danabr mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Aug 19, 2019
    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 11, 2019

    New changeset 5209e58 by T. Wouters (Daniel Abrahamsson) in branch 'master':
    bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330)
    5209e58

    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 11, 2019

    New changeset 63eefc3 by T. Wouters (Miss Islington (bot)) in branch '3.8':
    bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15973)
    63eefc3

    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 11, 2019

    New changeset d126fbd by T. Wouters (Miss Islington (bot)) in branch '3.7':
    bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15974)
    d126fbd

    @Yhg1s
    Copy link
    Member

    Yhg1s commented Sep 11, 2019

    Thanks, fix merged.

    @Yhg1s Yhg1s closed this as completed Sep 11, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @TomiBelan TomiBelan mentioned this issue Nov 29, 2023
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @Yhg1s