classification
Title: venv: Don't produce unbound variable warning on deactivate
Type: enhancement Stage: resolved
Components: Library (Lib) Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: danabr, twouters
Priority: normal Keywords: patch

Created on 2019-08-19 08:50 by danabr, last changed 2019-09-11 15:57 by twouters. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 15330 merged danabr, 2019-08-19 08:51
PR 15973 merged miss-islington, 2019-09-11 15:00
PR 15974 merged miss-islington, 2019-09-11 15:00
Messages (5)
msg349944 - (view) Author: Daniel Abrahamsson (danabr) * Date: 2019-08-19 08:50
Running deactivate from a bash shell configured to treat undefined variables as errors (`set -u`) produces a warning:

``` 
$ python3 -m venv test
$ source test/bin/activate
(test) $ deactivate
-bash: $1: unbound variable
```
msg351918 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-11 14:58
New changeset 5209e586b7cac9a43b2c44349a26b1b0af06ead3 by T. Wouters (Daniel Abrahamsson) in branch 'master':
bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15330)
https://github.com/python/cpython/commit/5209e586b7cac9a43b2c44349a26b1b0af06ead3
msg351955 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-11 15:56
New changeset 63eefc35674ec12ab4d00af4feaf21de4cb1c91c by T. Wouters (Miss Islington (bot)) in branch '3.8':
bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15973)
https://github.com/python/cpython/commit/63eefc35674ec12ab4d00af4feaf21de4cb1c91c
msg351957 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-11 15:56
New changeset d126fbddc960afd93ff070bc34209be256152943 by T. Wouters (Miss Islington (bot)) in branch '3.7':
bpo-37885: venv: Don't produce unbound variable warning on deactivate (GH-15974)
https://github.com/python/cpython/commit/d126fbddc960afd93ff070bc34209be256152943
msg351958 - (view) Author: Thomas Wouters (twouters) * (Python committer) Date: 2019-09-11 15:57
Thanks, fix merged.
History
Date User Action Args
2019-09-11 15:57:27twouterssetstatus: open -> closed
resolution: fixed
messages: + msg351958

stage: patch review -> resolved
2019-09-11 15:56:31twouterssetmessages: + msg351957
2019-09-11 15:56:00twouterssetmessages: + msg351955
2019-09-11 15:00:17miss-islingtonsetpull_requests: + pull_request15607
2019-09-11 15:00:10miss-islingtonsetpull_requests: + pull_request15606
2019-09-11 14:58:59twouterssetnosy: + twouters
messages: + msg351918
2019-08-19 08:51:28danabrsetkeywords: + patch
stage: patch review
pull_requests: + pull_request15048
2019-08-19 08:50:09danabrcreate