Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows build when --no-tkinter is specified #81469

Closed
paulmon mannequin opened this issue Jun 14, 2019 · 5 comments
Closed

Fix Windows build when --no-tkinter is specified #81469

paulmon mannequin opened this issue Jun 14, 2019 · 5 comments
Assignees
@zooba
Labels
3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows

Comments

@paulmon
Copy link
Mannequin

paulmon mannequin commented Jun 14, 2019

BPO 37288
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington, @paulmon
PRs
  • bpo-37288: Fix Windows build when --no-tkinter is specified #14096
  • [3.8] bpo-37288: Fix Windows build when --no-tkinter is specified (GH-14096) #14160
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2019-06-17.15:24:03.200>
created_at = <Date 2019-06-14.23:36:17.004>
labels = ['build', '3.8', '3.9', 'OS-windows']
title = 'Fix Windows build when --no-tkinter is specified'
updated_at = <Date 2019-06-17.15:48:02.960>
user = 'https://github.com/paulmon'

    bugs.python.org fields:

    activity = <Date 2019-06-17.15:48:02.960>
actor = 'miss-islington'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2019-06-17.15:24:03.200>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2019-06-14.23:36:17.004>
creator = 'Paul Monson'
dependencies = []
files = []
hgrepos = []
issue_num = 37288
keywords = ['patch']
message_count = 5.0
messages = ['345648', '345649', '345864', '345866', '345869']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington', 'Paul Monson']
pr_nums = ['14096', '14160']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue37288'
versions = ['Python 3.8', 'Python 3.9']
    @paulmon
    Copy link
    Mannequin Author

    paulmon mannequin commented Jun 14, 2019

    #14065 breaks building with --no-tkinter. Which breaks the Windows arm32 buildbot

    C:\Users\buildbot\buildarea\3.x.monson-win-arm32.nondebug\build\PCbuild\python.vcxproj(158,9): error MSB4184: The expression "[System.IO.File]::ReadAllText(C:\Users\buildbot\buildarea\3.x.monson-win-arm32.nondebug\build\externals\tcltk-8.6.9.0\arm32\tcllicense.terms)" cannot be evaluated. Could not find a part of the path 'C:\Users\buildbot\buildarea\3.x.monson-win-arm32.nondebug\build\externals\tcltk-8.6.9.0\arm32\tcllicense.terms'.

    @paulmon paulmon mannequin added 3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows labels Jun 14, 2019
    @paulmon
    Copy link
    Mannequin Author

    paulmon mannequin commented Jun 14, 2019

    Change title: Fix Windows build when --no-tkinter is specified
    I noticed this because the Windows arm32 buildbot build was broken.

    @paulmon paulmon mannequin changed the title Windows arm32 buildbot build is broken Fix Windows build when --no-tkinter is specified Jun 14, 2019
    @zooba
    Copy link
    Member

    zooba commented Jun 17, 2019

    New changeset 00f6493 by Steve Dower (Paul Monson) in branch 'master':
    bpo-37288: Fix Windows build when --no-tkinter is specified (GH-14096)
    00f6493

    @zooba
    Copy link
    Member

    zooba commented Jun 17, 2019

    Thanks, Paul!

    @zooba zooba closed this as completed Jun 17, 2019
    @zooba zooba self-assigned this Jun 17, 2019
    @miss-islington
    Copy link
    Contributor

    New changeset 79d8204 by Miss Islington (bot) in branch '3.8':
    bpo-37288: Fix Windows build when --no-tkinter is specified (GH-14096)
    79d8204

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.8 only security fixes 3.9 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @zooba @miss-islington