Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_asyncio: ProactorLoopCtrlC leaks one reference #81459

Closed
vstinner opened this issue Jun 14, 2019 · 7 comments
Closed

test_asyncio: ProactorLoopCtrlC leaks one reference #81459

vstinner opened this issue Jun 14, 2019 · 7 comments
Labels
3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir topic-asyncio

Comments

@vstinner
Copy link
Member

BPO 37278
Nosy @vstinner, @asvetlov, @1st1, @miss-islington
PRs
  • bpo-37278: Fix test_asyncio ProactorLoopCtrlC #14074
  • [3.8] bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074) #14077
  • [3.8] bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074) #14078
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-06-14.12:15:31.718>
created_at = <Date 2019-06-14.10:19:11.566>
labels = ['3.8', 'tests', '3.9', 'expert-asyncio']
title = 'test_asyncio: ProactorLoopCtrlC leaks one reference'
updated_at = <Date 2019-06-14.13:30:48.040>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2019-06-14.13:30:48.040>
actor = 'asvetlov'
assignee = 'none'
closed = True
closed_date = <Date 2019-06-14.12:15:31.718>
closer = 'vstinner'
components = ['Tests', 'asyncio']
creation = <Date 2019-06-14.10:19:11.566>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 37278
keywords = ['patch']
message_count = 7.0
messages = ['345570', '345573', '345579', '345581', '345588', '345590', '345594']
nosy_count = 4.0
nosy_names = ['vstinner', 'asvetlov', 'yselivanov', 'miss-islington']
pr_nums = ['14074', '14077', '14078']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue37278'
versions = ['Python 3.8', 'Python 3.9']
    @vstinner
    Copy link
    Member Author

    vstinner@WIN C:\vstinner\python\master>python -m test -R 3:3 test_asyncio -m test.test_asyncio.test_windows_events.ProactorLoopCtrlC.test_ctrl_c
    Running Debug|x64 interpreter...
    Run tests sequentially
    0:00:00 load avg: 0.00 [1/1] test_asyncio
    beginning 6 repetitions
    123456
    ......
    test_asyncio leaked [1, 1, 1] references, sum=3
    test_asyncio leaked [2, 1, 1] memory blocks, sum=4
    test_asyncio failed

    == Tests result: FAILURE ==

    1 test failed:
    test_asyncio

    Total duration: 13 sec 391 ms
    Tests result: FAILURE

    Attached PR fix the issue by joining the thread.

    @vstinner vstinner added 3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir topic-asyncio labels Jun 14, 2019
    @vstinner
    Copy link
    Member Author

    bpo-34520 *might* be an old duplicate of this bug.

    @asvetlov
    Copy link
    Contributor

    Maybe. Agree with your decision to close bpo-34520 as duplicate.

    @vstinner
    Copy link
    Member Author

    New changeset 0755945 by Victor Stinner in branch 'master':
    bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074)
    0755945

    @miss-islington
    Copy link
    Contributor

    New changeset 8b66dbb by Miss Islington (bot) in branch '3.8':
    bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074)
    8b66dbb

    @vstinner
    Copy link
    Member Author

    Thanks for the review Andrew.

    @asvetlov
    Copy link
    Contributor

    Welcome!
    Thanks for the fix!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.8 only security fixes 3.9 only security fixes tests Tests in the Lib/test dir topic-asyncio
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    3 participants
    @vstinner @asvetlov @miss-islington