Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 589: add TypedDict to typing #81230

Closed
ilevkivskyi opened this issue May 25, 2019 · 4 comments
Closed

Implement PEP 589: add TypedDict to typing #81230

ilevkivskyi opened this issue May 25, 2019 · 4 comments
Assignees
@ilevkivskyi
Labels
3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@ilevkivskyi
Copy link
Member

BPO 37049
Nosy @gvanrossum, @ilevkivskyi, @yan12125
PRs
  • bpo-37049: PEP 589: Add TypedDict to typing module #13573
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ilevkivskyi'
closed_at = <Date 2019-05-26.08:43:08.259>
created_at = <Date 2019-05-25.19:44:49.957>
labels = ['3.8', 'type-feature', 'library']
title = 'Implement PEP 589: add TypedDict to typing'
updated_at = <Date 2019-05-26.12:45:24.113>
user = 'https://github.com/ilevkivskyi'

    bugs.python.org fields:

    activity = <Date 2019-05-26.12:45:24.113>
actor = 'yan12125'
assignee = 'levkivskyi'
closed = True
closed_date = <Date 2019-05-26.08:43:08.259>
closer = 'levkivskyi'
components = ['Library (Lib)']
creation = <Date 2019-05-25.19:44:49.957>
creator = 'levkivskyi'
dependencies = []
files = []
hgrepos = []
issue_num = 37049
keywords = ['patch']
message_count = 4.0
messages = ['343506', '343540', '343541', '343547']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'SilentGhost', 'levkivskyi', 'yan12125']
pr_nums = ['13573']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37049'
versions = ['Python 3.8']
    @ilevkivskyi
    Copy link
    Member Author

    The actual implementation is performed by type checkers like mypy. We just need to add TypedDict to the typing module.

    @ilevkivskyi ilevkivskyi added the 3.8 only security fixes label May 25, 2019
    @ilevkivskyi ilevkivskyi self-assigned this May 25, 2019
    @ilevkivskyi ilevkivskyi added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels May 25, 2019
    @ilevkivskyi
    Copy link
    Member Author

    New changeset 135c6a5 by Ivan Levkivskyi in branch 'master':
    bpo-37049: PEP-589: Add TypedDict to typing module (GH-13573)
    135c6a5

    @SilentGhost
    Copy link
    Mannequin

    SilentGhost mannequin commented May 26, 2019

    Either 135c6a5 or b891c46 (bpo-37046) broke the build. Lib/test/test_typing.py does not round-trip.

    @yan12125
    Copy link
    Mannequin

    yan12125 mannequin commented May 26, 2019

    Regarding the round-trip issue in Lib/test/test_typing.py mentioned by SilentGhost:

    Apparently the following line added in b891c46 triggers an issue in Tools/parser/unparse.py

    Literal[b"foo", u"bar"]

    As this is more likely an issue in unparse.py instead of test_typing.py, I opened another ticket for tracking: bpo-37053.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @ilevkivskyi ilevkivskyi

    Labels
    3.8 only security fixes stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @ilevkivskyi