classification
Title: Implement PEP 589: add TypedDict to typing
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: levkivskyi Nosy List: SilentGhost, gvanrossum, levkivskyi, yan12125
Priority: normal Keywords: patch

Created on 2019-05-25 19:44 by levkivskyi, last changed 2019-05-26 12:45 by yan12125. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 13573 merged levkivskyi, 2019-05-25 19:47
Messages (4)
msg343506 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2019-05-25 19:44
The actual implementation is performed by type checkers like mypy. We just need to add `TypedDict` to the `typing` module.
msg343540 - (view) Author: Ivan Levkivskyi (levkivskyi) * (Python committer) Date: 2019-05-26 08:39
New changeset 135c6a56e55d2f4f8718b3b9f03ce3c692b15f0f by Ivan Levkivskyi in branch 'master':
bpo-37049: PEP 589: Add TypedDict to typing module (GH-13573)
https://github.com/python/cpython/commit/135c6a56e55d2f4f8718b3b9f03ce3c692b15f0f
msg343541 - (view) Author: SilentGhost (SilentGhost) * (Python triager) Date: 2019-05-26 09:19
Either 135c6a56e55d2f4f8718b3b9f03ce3c692b15f0f or b891c465bb7d38a597c5c2ad547d7b19194f4dad (#37046) broke the build. Lib/test/test_typing.py does not round-trip.
msg343547 - (view) Author: Chih-Hsuan Yen (yan12125) * Date: 2019-05-26 12:45
Regarding the round-trip issue in Lib/test/test_typing.py mentioned by SilentGhost:

Apparently the following line added in b891c465bb7d38a597c5c2ad547d7b19194f4dad triggers an issue in Tools/parser/unparse.py

    Literal[b"foo", u"bar"]

As this is more likely an issue in unparse.py instead of test_typing.py, I opened another ticket for tracking: #37053.
History
Date User Action Args
2019-05-26 12:45:24yan12125setmessages: + msg343547
2019-05-26 10:31:23yan12125setnosy: + yan12125
2019-05-26 09:19:18SilentGhostsetnosy: + SilentGhost
messages: + msg343541
2019-05-26 08:43:08levkivskyisetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2019-05-26 08:39:29levkivskyisetmessages: + msg343540
2019-05-25 19:47:25levkivskyisetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request13481
2019-05-25 19:44:49levkivskyicreate