Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_descr: test_vicious_descriptor_nonsense() fails randomly #80291

Closed
vstinner opened this issue Feb 25, 2019 · 3 comments
Closed

test_descr: test_vicious_descriptor_nonsense() fails randomly #80291

vstinner opened this issue Feb 25, 2019 · 3 comments
Labels
3.8 only security fixes tests Tests in the Lib/test dir

Comments

@vstinner
Copy link
Member

BPO 36110
Nosy @vstinner, @serhiy-storchaka, @pablogsal

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2019-02-25.23:23:25.819>
created_at = <Date 2019-02-25.21:45:42.795>
labels = ['3.8', 'tests']
title = 'test_descr: test_vicious_descriptor_nonsense() fails randomly'
updated_at = <Date 2019-02-25.23:23:47.100>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2019-02-25.23:23:47.100>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-25.23:23:25.819>
closer = 'pablogsal'
components = ['Tests']
creation = <Date 2019-02-25.21:45:42.795>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 36110
keywords = []
message_count = 3.0
messages = ['336562', '336575', '336576']
nosy_count = 3.0
nosy_names = ['vstinner', 'serhiy.storchaka', 'pablogsal']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue36110'
versions = ['Python 3.8']
@vstinner
Copy link
Member Author

test_vicious_descriptor_nonsense() started to fails randomly:

$ ./python -m test -j0 -F test_descr test_descr test_descr test_descr test_descr test_descr
Run tests in parallel using 10 child processes
0:00:03 load avg: 1.24 [1/6] test_descr passed
0:00:03 load avg: 1.70 [2/6/1] test_descr failed
test test_descr failed -- Traceback (most recent call last):
  File "/home/vstinner/prog/python/master/Lib/test/test_descr.py", line 4341, in test_vicious_descriptor_nonsense
    self.assertEqual(c.attr, 1)
  File "/home/vstinner/prog/python/master/Lib/test/test_descr.py", line 4328, in __eq__
    del C.attr
AttributeError: attr
0:00:03 load avg: 1.70 [3/6/1] test_descr passed
0:00:04 load avg: 1.70 [4/6/1] test_descr passed
0:00:04 load avg: 1.70 [5/6/1] test_descr passed
0:00:04 load avg: 1.70 [6/6/1] test_descr passed

== Tests result: FAILURE ==

5 tests OK.

1 test failed:
test_descr

Total duration: 4 sec 213 ms
Tests result: FAILURE

--

It seems like it's a regression introduced by this change:

a24107b is the first bad commit
commit a24107b
Author: Serhiy Storchaka <storchaka@gmail.com>
Date: Mon Feb 25 17:59:46 2019 +0200

bpo-35459: Use PyDict_GetItemWithError() instead of PyDict_GetItem(). (GH-11112)

:040000 040000 da22597a443c84fb29588a3557f5dd04e292a1cc fb73df9fbfdc1893e9f0bde9fbc6ab6febabbe8f M Include
:040000 040000 4b26a84a0e3a813470e34ddef29596da41d3d28f ca6192ea98e014434a32e2a114e42b297408ce00 M Modules
:040000 040000 b2dd7d4e832c64ba44781a34093c5d69ea127932 26bfeced0b5776634051ed57d701361252c6de68 M Objects
:040000 040000 6b5a0bf3a25434ee3de5c9dae3e880217773c0fb 56265d6d2cd8cb92ba47541909af2edec46196e6 M Python

@vstinner vstinner added 3.8 only security fixes tests Tests in the Lib/test dir labels Feb 25, 2019
@pablogsal
Copy link
Member

Duplicate of https://bugs.python.org/issue36109

@pablogsal
Copy link
Member

I was faster this time ;)

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.8 only security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @pablogsal