Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiprocessing: provide unit-tests for manager classes and shareable types #80098

Closed
giampaolo opened this issue Feb 6, 2019 · 6 comments
Closed

multiprocessing: provide unit-tests for manager classes and shareable types #80098

giampaolo opened this issue Feb 6, 2019 · 6 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@giampaolo
Copy link
Contributor

BPO 35917
Nosy @pitrou, @giampaolo, @applio
PRs
  • bpo-35917: Test multiprocessing manager classes and shareable types #11772
  • bpo-35917: Test multiprocessing manager classes and shareable types #11772
  • bpo-35917: Test multiprocessing manager classes and shareable types #11772
  • [3.7] bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772) #11780
  • [3.7] bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772) #11780
  • [3.7] bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772) #11780
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2019-02-07.11:34:54.695>
created_at = <Date 2019-02-06.16:35:19.922>
labels = ['3.7', '3.8', 'type-feature', 'tests']
title = 'multiprocessing: provide unit-tests for manager classes and shareable types'
updated_at = <Date 2019-02-07.11:34:54.694>
user = 'https://github.com/giampaolo'

    bugs.python.org fields:

    activity = <Date 2019-02-07.11:34:54.694>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2019-02-07.11:34:54.695>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2019-02-06.16:35:19.922>
creator = 'giampaolo.rodola'
dependencies = []
files = []
hgrepos = []
issue_num = 35917
keywords = ['patch', 'patch', 'patch']
message_count = 6.0
messages = ['334952', '334954', '334955', '335010', '335011', '335012']
nosy_count = 3.0
nosy_names = ['pitrou', 'giampaolo.rodola', 'davin']
pr_nums = ['11772', '11772', '11772', '11780', '11780', '11780']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue35917'
versions = ['Python 3.7', 'Python 3.8']
    @giampaolo
    Copy link
    Contributor Author

    This is a follow up of BPO-35813 and PR-11664 and it provides unit tests for SyncManager and SharedMemoryManager classes + all the shareable types which are supposed to be supported by them. Also, see relevant python-dev discussion at: https://mail.python.org/pipermail/python-dev/2019-February/156235.html.

    In doing so I discovered a couple of issues which I will treat in a separate BPO ticket (multiprocessing.managers's dict.has_key() and Pool() appear to be broken).

    @giampaolo giampaolo added 3.8 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Feb 6, 2019
    @pitrou
    Copy link
    Member

    pitrou commented Feb 6, 2019

    Interesting. I had never looked too closely and assumed this was already tested.

    @pitrou
    Copy link
    Member

    pitrou commented Feb 6, 2019

    Would probably be worthwhile backporting to 3.7 as well.

    @pitrou pitrou added the 3.7 (EOL) end of life label Feb 6, 2019
    @pitrou
    Copy link
    Member

    pitrou commented Feb 7, 2019

    New changeset 2848d9d by Antoine Pitrou (Giampaolo Rodola) in branch 'master':
    bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772)
    2848d9d

    @pitrou
    Copy link
    Member

    pitrou commented Feb 7, 2019

    New changeset 15526f5 by Antoine Pitrou in branch '3.7':
    [3.7] bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772) (GH-11780)
    15526f5

    @pitrou
    Copy link
    Member

    pitrou commented Feb 7, 2019

    Thanks Giampaolo!

    @pitrou pitrou closed this as completed Feb 7, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.7 (EOL) end of life 3.8 only security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @giampaolo @pitrou