Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Almost all Windows buildbots are failing to compile #79618

Closed
pablogsal opened this issue Dec 7, 2018 · 10 comments
Closed

Almost all Windows buildbots are failing to compile #79618

pablogsal opened this issue Dec 7, 2018 · 10 comments
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows

Comments

@pablogsal
Copy link
Member

BPO 35437
Nosy @pfmoore, @vstinner, @tjguk, @ned-deily, @zware, @zooba, @pablogsal

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-07.15:38:06.622>
created_at = <Date 2018-12-07.09:57:18.306>
labels = ['interpreter-core', '3.7', '3.8', 'OS-windows']
title = 'Almost all Windows buildbots are failing to compile'
updated_at = <Date 2018-12-07.15:38:06.620>
user = 'https://github.com/pablogsal'

bugs.python.org fields:

activity = <Date 2018-12-07.15:38:06.620>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-07.15:38:06.622>
closer = 'vstinner'
components = ['Interpreter Core', 'Windows']
creation = <Date 2018-12-07.09:57:18.306>
creator = 'pablogsal'
dependencies = []
files = []
hgrepos = []
issue_num = 35437
keywords = []
message_count = 10.0
messages = ['331283', '331284', '331286', '331289', '331291', '331294', '331299', '331314', '331317', '331327']
nosy_count = 7.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'pablogsal']
pr_nums = []
priority = None
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35437'
versions = ['Python 3.7', 'Python 3.8']
@pablogsal
Copy link
Member Author

Almost all Windows buildbots are failing to compile Python:

https://buildbot.python.org/all/#/builders/130/builds/525
https://buildbot.python.org/all/#/builders/113/builds/825
https://buildbot.python.org/all/#/builders/121/builds/782
https://buildbot.python.org/all/#/builders/58/builds/1680
https://buildbot.python.org/all/#/builders/17/builds/494
...

I suspect that is due to this commit:

468a15a

and its backports.

@pablogsal pablogsal added release-blocker 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows 3.7 (EOL) end of life labels Dec 7, 2018
@pablogsal
Copy link
Member Author

468a15a

@pablogsal
Copy link
Member Author

Reverting that commit seem to work:

https://buildbot.python.org/all/#/builders/91/builds/9

@pablogsal
Copy link
Member Author

More broken buildbots:
https://buildbot.python.org/all/#/builders/32/builds/1867

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

https://buildbot.python.org/all/#/builders/121/builds/782

41>d:\buildarea\3.7.bolen-windows10\build\pc\python_uwp.cpp(9): fatal error C1083: Cannot open include file: 'winrt\Windows.ApplicationModel.h': No such file or directory [D:\buildarea\3.7.bolen-windows10\build\PCbuild\python_uwp.vcxproj]

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

https://buildbot.python.org/all/#/builders/17/builds/494

     C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\x64\PlatformToolsets\v140\Toolset.targets(36,5): error MSB8036: The Windows SDK version 10.0.15063.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\buildbot.python.org\3.6.kloth-win64\build\PCbuild\pythoncore.vcxproj]

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

See also bpo-35433: "Correctly detect installed SDK versions".

@zooba
Copy link
Member

zooba commented Dec 7, 2018

Okay, so apparently the buildbots are still building with VS 2015, and not VS 2017.

I'll add a check for the new executable and repush. This was caused solely by the new code and not by any of the changes to existing code.

@pablogsal
Copy link
Member Author

@Steve Notice that 468a15a is currently reverted, so you need to push it again if you plan to add something on top of it.

@vstinner
Copy link
Member

vstinner commented Dec 7, 2018

I revert the changes, so buildbots should go back to green. I asked Steve Dower to use a custom build to avoid such hiccup on the next attempt to merge his change.

@vstinner vstinner closed this as completed Dec 7, 2018
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.7 (EOL) end of life 3.8 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @zooba @pablogsal