classification
Title: Almost all Windows buildbots are failing to compile
Type: Stage: resolved
Components: Interpreter Core, Windows Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ned.deily, pablogsal, paul.moore, steve.dower, tim.golden, vstinner, zach.ware
Priority: Keywords:

Created on 2018-12-07 09:57 by pablogsal, last changed 2018-12-07 15:38 by vstinner. This issue is now closed.

Messages (10)
msg331283 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-12-07 09:57
Almost all Windows buildbots are failing to compile Python:

https://buildbot.python.org/all/#/builders/130/builds/525
https://buildbot.python.org/all/#/builders/113/builds/825
https://buildbot.python.org/all/#/builders/121/builds/782
https://buildbot.python.org/all/#/builders/58/builds/1680
https://buildbot.python.org/all/#/builders/17/builds/494
...

I suspect that is due to this commit:

468a15a 

and its backports.
msg331284 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-12-07 10:00
https://github.com/python/cpython/commit/468a15aaf9206448a744fc5eab3fc21f51966aad
msg331286 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-12-07 10:11
Reverting that commit seem to work:

https://buildbot.python.org/all/#/builders/91/builds/9
msg331289 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-12-07 10:42
More broken buildbots:
https://buildbot.python.org/all/#/builders/32/builds/1867
msg331291 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-12-07 11:24
> https://buildbot.python.org/all/#/builders/121/builds/782

    41>d:\buildarea\3.7.bolen-windows10\build\pc\python_uwp.cpp(9): fatal error C1083: Cannot open include file: 'winrt\Windows.ApplicationModel.h': No such file or directory [D:\buildarea\3.7.bolen-windows10\build\PCbuild\python_uwp.vcxproj]
msg331294 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-12-07 11:26
> https://buildbot.python.org/all/#/builders/17/builds/494

         C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\x64\PlatformToolsets\v140\Toolset.targets(36,5): error MSB8036: The Windows SDK version 10.0.15063.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\buildbot.python.org\3.6.kloth-win64\build\PCbuild\pythoncore.vcxproj]
msg331299 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-12-07 11:43
See also bpo-35433: "Correctly detect installed SDK versions".
msg331314 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-12-07 14:08
Okay, so apparently the buildbots are still building with VS 2015, and not VS 2017.

I'll add a check for the new executable and repush. This was caused solely by the new code and not by any of the changes to existing code.
msg331317 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2018-12-07 14:34
@Steve Notice that 468a15aaf9206448a744fc5eab3fc21f51966aad is currently reverted, so you need to push it again if you plan to add something on top of it.
msg331327 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-12-07 15:38
I revert the changes, so buildbots should go back to green. I asked Steve Dower to use a custom build to avoid such hiccup on the next attempt to merge his change.
History
Date User Action Args
2018-12-07 15:38:06vstinnersetstatus: open -> closed
priority: release blocker ->
messages: + msg331327

resolution: fixed
stage: resolved
2018-12-07 14:34:06pablogsalsetmessages: + msg331317
2018-12-07 14:08:50steve.dowersetmessages: + msg331314
2018-12-07 11:43:56vstinnersetmessages: + msg331299
2018-12-07 11:26:54vstinnersetmessages: + msg331294
2018-12-07 11:24:42vstinnersetnosy: + vstinner
messages: + msg331291
2018-12-07 10:42:53pablogsalsetmessages: + msg331289
2018-12-07 10:11:06pablogsalsetmessages: + msg331286
2018-12-07 10:00:57pablogsalsetmessages: + msg331284
versions: - Python 3.6
2018-12-07 09:57:22pablogsalsetnosy: + ned.deily

versions: + Python 3.6, Python 3.7
2018-12-07 09:57:18pablogsalcreate