Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _Py_REF_DEBUG_COMMA #79411

Closed
methane opened this issue Nov 13, 2018 · 5 comments
Closed

Remove _Py_REF_DEBUG_COMMA #79411

methane opened this issue Nov 13, 2018 · 5 comments

Comments

@methane
Copy link
Member

methane commented Nov 13, 2018

BPO 35230
Nosy @vstinner, @methane
PRs
  • bpo-35230: dict: Remove some macros #10513
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2018-11-14.09:40:19.347>
created_at = <Date 2018-11-13.12:08:45.039>
labels = []
title = 'Remove _Py_REF_DEBUG_COMMA'
updated_at = <Date 2018-11-14.10:07:11.809>
user = 'https://github.com/methane'

    bugs.python.org fields:

    activity = <Date 2018-11-14.10:07:11.809>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2018-11-14.09:40:19.347>
closer = 'methane'
components = []
creation = <Date 2018-11-13.12:08:45.039>
creator = 'methane'
dependencies = []
files = []
hgrepos = []
issue_num = 35230
keywords = ['patch']
message_count = 5.0
messages = ['329833', '329835', '329841', '329894', '329896']
nosy_count = 2.0
nosy_names = ['vstinner', 'methane']
pr_nums = ['10513']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35230'
versions = []
    @methane
    Copy link
    Member Author

    methane commented Nov 13, 2018

    After 2aaf0c, _Py_REF_DEBUG_COMMA in Include/object.h is used only in dictobject.c. Let's remove it.

    @methane
    Copy link
    Member Author

    methane commented Nov 13, 2018

    I meant 2aaf0c1.

    @vstinner
    Copy link
    Member

    This change is related to bpo-35059.

    @methane
    Copy link
    Member Author

    methane commented Nov 14, 2018

    New changeset a757649 by INADA Naoki in branch 'master':
    bpo-35230: dict: Remove some macros (GH-10513)
    a757649

    @methane methane closed this as completed Nov 14, 2018
    @vstinner
    Copy link
    Member

    Thanks. I almost started my project to convert macros to static inline functions just to remove ugly things like:

    #define _Py_REF_DEBUG_COMMA ,

    (Well, there are other reasons to move to proper functions.)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @methane