classification
Title: Remove _Py_REF_DEBUG_COMMA
Type: Stage: resolved
Components: Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: inada.naoki, vstinner
Priority: normal Keywords: patch

Created on 2018-11-13 12:08 by inada.naoki, last changed 2018-11-14 10:07 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 10513 merged inada.naoki, 2018-11-13 12:13
Messages (5)
msg329833 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-11-13 12:08
After 2aaf0c, _Py_REF_DEBUG_COMMA in Include/object.h is used only in dictobject.c.  Let's remove it.
msg329835 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-11-13 12:11
I meant 2aaf0c1.
msg329841 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-11-13 13:57
This change is related to bpo-35059.
msg329894 - (view) Author: Inada Naoki (inada.naoki) * (Python committer) Date: 2018-11-14 09:39
New changeset a757649fd6535c5e65481eb1077e30687421b92b by INADA Naoki in branch 'master':
bpo-35230: dict: Remove some macros (GH-10513)
https://github.com/python/cpython/commit/a757649fd6535c5e65481eb1077e30687421b92b
msg329896 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2018-11-14 10:07
Thanks. I almost started my project to convert macros to static inline functions just to remove ugly things like:

#define _Py_REF_DEBUG_COMMA ,


(Well, there are other reasons to move to proper functions.)
History
Date User Action Args
2018-11-14 10:07:11vstinnersetmessages: + msg329896
2018-11-14 09:40:19inada.naokisetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-11-14 09:39:39inada.naokisetmessages: + msg329894
2018-11-13 13:57:01vstinnersetnosy: + vstinner
messages: + msg329841
2018-11-13 12:13:29inada.naokisetkeywords: + patch
stage: patch review
pull_requests: + pull_request9773
2018-11-13 12:11:34inada.naokisetmessages: + msg329835
2018-11-13 12:08:45inada.naokicreate