Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDLE: rename windows.py as window.py #78087

Closed
terryjreedy opened this issue Jun 19, 2018 · 6 comments
Closed

IDLE: rename windows.py as window.py #78087

terryjreedy opened this issue Jun 19, 2018 · 6 comments
Assignees
@terryjreedy
Labels
3.7 (EOL) end of life 3.8 only security fixes easy topic-IDLE type-feature A feature request or enhancement

Comments

@terryjreedy
Copy link
Member

BPO 33906
Nosy @terryjreedy, @miss-islington
PRs
  • bpo-33906: Rename idlelib.windows as window #7833
  • [3.7] bpo-33906: Rename idlelib.windows as window (GH-7833) #7834
  • [3.6] bpo-33906: Rename idlelib.windows as window (GH-7833) #7835
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2018-06-21.02:05:06.133>
created_at = <Date 2018-06-19.22:52:37.436>
labels = ['easy', '3.8', 'expert-IDLE', 'type-feature', '3.7']
title = 'IDLE: rename windows.py as window.py'
updated_at = <Date 2018-06-21.02:05:06.133>
user = 'https://github.com/terryjreedy'

    bugs.python.org fields:

    activity = <Date 2018-06-21.02:05:06.133>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2018-06-21.02:05:06.133>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2018-06-19.22:52:37.436>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 33906
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['320003', '320027', '320122', '320129', '320131', '320132']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'miss-islington']
pr_nums = ['7833', '7834', '7835']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33906'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']
    @terryjreedy
    Copy link
    Member Author

    Change module 'windows' to 'window'::

    1. 'calltips' and 'windows' are the only two plural module names.
    2. The top menu entry was changed from 'Windows' to 'Window' some time ago.
    3. 'windows' is also a OS.

    With all modules at least imported in a test, all imports in modules should be checked, so running test_idle after changing the file name should reveal all imports that need to be changed.

    What could have been the 'Window' class is called 'ListedTopLevel'.

    @terryjreedy terryjreedy added 3.7 (EOL) end of life 3.8 only security fixes labels Jun 19, 2018
    @terryjreedy terryjreedy self-assigned this Jun 19, 2018
    @terryjreedy terryjreedy added topic-IDLE type-feature A feature request or enhancement labels Jun 19, 2018
    @terryjreedy terryjreedy changed the title IDLE: change windows.py to window.py IDLE: rename windows.py as window.py Jun 19, 2018
    @terryjreedy
    Copy link
    Member Author

    Also rename idle_test.test_windows as test_window with git mv. Imports:

    F:\dev\3x\lib\idlelib\editor.py: 28: from idlelib import windows
    F:\dev\3x\lib\idlelib\idle_test\test_windows.py: 3: from idlelib import windows
    F:\dev\3x\lib\idlelib\macosx.py: 131: from idlelib import windows

    @terryjreedy
    Copy link
    Member Author

    Marking 2.7 for a search test.

    @terryjreedy
    Copy link
    Member Author

    New changeset a361e89 by Terry Jan Reedy in branch 'master':
    bpo-33906: Rename idlelib.windows as window (bpo-7833)
    a361e89

    @miss-islington
    Copy link
    Contributor

    New changeset f9243a2 by Miss Islington (bot) in branch '3.7':
    bpo-33906: Rename idlelib.windows as window (GH-7833)
    f9243a2

    @miss-islington
    Copy link
    Contributor

    New changeset 2839da4 by Miss Islington (bot) in branch '3.6':
    bpo-33906: Rename idlelib.windows as window (GH-7833)
    2839da4

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @terryjreedy terryjreedy

    Labels
    3.7 (EOL) end of life 3.8 only security fixes easy topic-IDLE type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @terryjreedy @miss-islington