Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] PCbuild error: A numeric comparison was attempted #76138

Closed
vstinner opened this issue Nov 6, 2017 · 6 comments
Closed

[Windows] PCbuild error: A numeric comparison was attempted #76138

vstinner opened this issue Nov 6, 2017 · 6 comments
Assignees
@zooba
Labels
3.7 (EOL) end of life build The build process and cross-build OS-windows

Comments

@vstinner
Copy link
Member

vstinner commented Nov 6, 2017

BPO 31957
Nosy @pfmoore, @vstinner, @tjguk, @zware, @zooba
PRs
  • bpo-31957: Fixes version detection. #4298
  • [3.6] bpo-31957: Fixes version detection. (GH-4298) #4300
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
closed_at = <Date 2017-11-07.22:55:44.561>
created_at = <Date 2017-11-06.11:17:26.009>
labels = ['build', '3.7', 'OS-windows']
title = '[Windows] PCbuild error: A numeric comparison was attempted'
updated_at = <Date 2017-11-07.22:55:44.560>
user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2017-11-07.22:55:44.560>
actor = 'vstinner'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2017-11-07.22:55:44.561>
closer = 'vstinner'
components = ['Build', 'Windows']
creation = <Date 2017-11-06.11:17:26.009>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 31957
keywords = ['patch']
message_count = 6.0
messages = ['305631', '305632', '305633', '305675', '305685', '305797']
nosy_count = 5.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'zach.ware', 'steve.dower']
pr_nums = ['4298', '4300']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue31957'
versions = ['Python 3.6', 'Python 3.7']
    @vstinner
    Copy link
    Member Author

    vstinner commented Nov 6, 2017

    http://buildbot.python.org/all/#/builders/58/builds/110

    Build started 11/4/2017 7:30:21 PM.
    Project "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\pythoncore.vcxproj" on node 1 (KillPython target(s)).
    D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python.props(77,31): error MSB4086: A numeric comparison was attempted on "$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Microsoft SDKs\Windows\v10.0@ProductVersion)" that evaluates to "" instead of a number, in condition "$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Microsoft SDKs\Windows\v10.0@ProductVersion) >= '10.0.15063'". [D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\pythoncore.vcxproj]
    Done Building Project "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\pythoncore.vcxproj" (KillPython target(s)) -- FAILED.
    Build FAILED.

    It's likely a regression caused by one of these commits:

    @vstinner vstinner added 3.7 (EOL) end of life build The build process and cross-build OS-windows labels Nov 6, 2017
    @vstinner
    Copy link
    Member Author

    vstinner commented Nov 6, 2017

    Compilation also failed on AMD64 Windows8 3.x:

    http://buildbot.python.org/all/#/builders/32/builds/118

    @vstinner
    Copy link
    Member Author

    vstinner commented Nov 6, 2017

    Windows8 error:

    D:\buildarea\3.x.bolen-windows8\build\PCbuild\python.props(76,31): error MSB4086: A numeric comparison was attempted on "$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v10.0@ProductVersion)" that evaluates to "" instead of a number, in condition "$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v10.0@ProductVersion) >= '10.0.15063'". [D:\buildarea\3.x.bolen-windows8\build\PCbuild\pythoncore.vcxproj]

    @zooba zooba self-assigned this Nov 6, 2017
    @zooba zooba added the build The build process and cross-build label Nov 6, 2017
    @zooba
    Copy link
    Member

    zooba commented Nov 6, 2017

    New changeset 30f4fa4 by Steve Dower in branch 'master':
    bpo-31957: Fixes version detection. (bpo-4298)
    30f4fa4

    @zooba
    Copy link
    Member

    zooba commented Nov 6, 2017

    New changeset a6ffec2 by Steve Dower (Miss Islington (bot)) in branch '3.6':
    [3.6] bpo-31957: Fixes version detection. (GH-4298) (bpo-4300)
    a6ffec2

    @vstinner
    Copy link
    Member Author

    vstinner commented Nov 7, 2017

    Thank you Steve for the quick fix!

    @vstinner vstinner closed this as completed Nov 7, 2017
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @zooba zooba

    Labels
    3.7 (EOL) end of life build The build process and cross-build OS-windows
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    2 participants
    @vstinner @zooba